Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Moving from make.py to Makefile for sphinx-build#9712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
NelleV wants to merge11 commits intomatplotlib:masterfromNelleV:5798_makefile
Closed

Moving from make.py to Makefile for sphinx-build#9712

NelleV wants to merge11 commits intomatplotlib:masterfromNelleV:5798_makefile

Conversation

NelleV
Copy link
Member

"We still use an ancient make.py that is based on what early versions of sphinx-quickstart used to generate. We should probably modernize this to use a Makefile like current versions of sphinx create."

closes#5798

@anntzer
Copy link
Contributor

I still think that#9513 is a better fix...

  • there's no need to install conda on circleci.
  • there's no need to introduce custom targets in the makefile, we can directly use the one provided by sphinx (which is also much shorter now).
  • there's no need to modify the units examples.

@dopplershift
Copy link
Contributor

Whydoes this PR change to use conda on circleci?

Also, I'm completely confused as to why this PR needs to change the examples while#9513 doesn't.

@efiring
Copy link
Member

@NelleV, what do you see as the advantages of this over#9513? The latter has the a priori advantage of brevity.

@NelleV
Copy link
MemberAuthor

I've closed my PR. Both solution work, and I really don't care which one gets in.

@efiring
Copy link
Member

@NelleV, thank you for getting this topic rolling.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Makefile for sphinx build
5 participants
@NelleV@anntzer@dopplershift@efiring@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp