Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX: set_url() without effect in the plot for instances of Tick#9696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
khyox wants to merge2 commits intomatplotlib:masterfromkhyox:patch-1
Closed
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletionslib/matplotlib/axis.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -306,6 +306,17 @@ def set_label2(self, s):
self.label2.set_text(s)
self.stale = True

def set_url(self, s):
"""
Set the url of label1 and label2

ACCEPTS: str
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you also callsuper(self, Tick).set_label(s)?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi Thomas, if you meant to add a call tosuper(Tick, self).set_url(s), I just added it, if not, I don't get it, sorry.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Travis is failing with that addition with someImageComparisonFailure: images not close errors. When calling the parent Artist's set_url() method it just doesself._url = url! Amazing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That is what I meant, thanks.

Can you reproduce the failures locally?

super(Tick, self).set_url(s)
self.label1.set_url(s)
self.label2.set_url(s)
self.stale = True

def _set_artist_props(self, a):
a.set_figure(self.figure)

Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp