Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: set_url() without effect in the plot for instances of Tick#9696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -306,6 +306,17 @@ def set_label2(self, s): | ||
self.label2.set_text(s) | ||
self.stale = True | ||
def set_url(self, s): | ||
""" | ||
Set the url of label1 and label2 | ||
ACCEPTS: str | ||
""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Can you also call There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Hi Thomas, if you meant to add a call to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Travis is failing with that addition with some There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. That is what I meant, thanks. Can you reproduce the failures locally? | ||
super(Tick, self).set_url(s) | ||
self.label1.set_url(s) | ||
self.label2.set_url(s) | ||
self.stale = True | ||
def _set_artist_props(self, a): | ||
a.set_figure(self.figure) | ||