Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove LaTeX checking in setup.py.#9571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove LaTeX checking in setup.py.#9571
Uh oh!
There was an error while loading.Please reload this page.
Conversation
We already have runtime tests for LaTeX and associated dependencies; thecheck in setup.py is not used for anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is the point? From time to time I found this checks helpful.
These checks are already available at runtime (as |
It is nice to catch the warning when you install rather than when something fails. |
But this only gets executed when installing from source rather than from a wheel or a conda package (which is likely the most common case where the warning would be useful...). |
Can we move this to (or do we already have?) a utility function at in the top level namespace like |
anntzer commentedOct 30, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
You mean these? :-)
(and a few others) We could unify all these into something like
(also including gs and inkscape, so not just latex deps) |
Yes, those. We should bundle them up into one summary function? |
That's what I proposed above (but you may have missed the edit :-)) |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm going to assume that#9639 will go in after minor modification, so I think the present PR should go in now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems reasonable to me.
We already have runtime tests for LaTeX and associated dependencies; the
check in setup.py is not used for anything.
PR Summary
PR Checklist