Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove LaTeX checking in setup.py.#9571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

anntzer
Copy link
Contributor

We already have runtime tests for LaTeX and associated dependencies; the
check in setup.py is not used for anything.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

We already have runtime tests for LaTeX and associated dependencies; thecheck in setup.py is not used for anything.
Copy link
Member

@KojoleyKojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What is the point? From time to time I found this checks helpful.

@anntzer
Copy link
ContributorAuthor

These checks are already available at runtime (asmatplotlib.checkdep_foo), when the check is arguably more useful (it is not like a build time option where we actually need to build a different version of matplotlib depending on whether tex is available; even with tex not present I can just first install matplotlib and then install tex and everything will work fine).

@tacaswelltacaswell added this to thev2.2 milestoneOct 30, 2017
@tacaswell
Copy link
Member

It is nice to catch the warning when you install rather than when something fails.

@anntzer
Copy link
ContributorAuthor

But this only gets executed when installing from source rather than from a wheel or a conda package (which is likely the most common case where the warning would be useful...).

@tacaswell
Copy link
Member

Can we move this to (or do we already have?) a utility function at in the top level namespace likecheck_latex_installation() -> Dict[packag_name, version or None]?

@anntzer
Copy link
ContributorAuthor

anntzer commentedOct 30, 2017
edited
Loading

You mean these? :-)

In [7]: matplotlib.checkdep_dvipng()Out[7]: '1.15'In [8]: matplotlib.checkdep_tex()/usr/bin/ipython:1: MatplotlibDeprecationWarning: The checkdep_tex function was deprecated in version 2.1.  #!/usr/bin/python3Out[8]: '3.14159265'In [9]: matplotlib.checkdep_ghostscript()Out[9]: ('gs', '9.22')

(and a few others)

We could unify all these into something like

matplotlib.list_installed_executables()--->{"depname": ("dep_executable", "version") or None}

(also including gs and inkscape, so not just latex deps)

@tacaswell
Copy link
Member

Yes, those. We should bundle them up into one summary function?

@anntzer
Copy link
ContributorAuthor

That's what I proposed above (but you may have missed the edit :-))

@tacaswell
Copy link
Member

👍

@anntzeranntzer mentioned this pull requestOct 31, 2017
6 tasks
@anntzeranntzer modified the milestones:needs sorting,v3.0Feb 15, 2018
@anntzeranntzer mentioned this pull requestFeb 23, 2018
6 tasks
Copy link
Member

@efiringefiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm going to assume that#9639 will go in after minor modification, so I think the present PR should go in now.

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable to me.

@jklymakjklymak merged commita81fdf5 intomatplotlib:masterMar 21, 2018
@anntzeranntzer deleted the remove-latex-entries-in-setup.py branchMarch 21, 2018 20:48
@anntzeranntzer mentioned this pull requestJan 28, 2019
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@KojoleyKojoleyKojoley left review comments

@efiringefiringefiring approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

5 participants
@anntzer@tacaswell@efiring@jklymak@Kojoley

[8]ページ先頭

©2009-2025 Movatter.jp