Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: Always update tick labels (fixes #9397)#9452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
NelleV merged 1 commit intomatplotlib:masterfromafvincent:fix_incorrect_labels_issue_9397Oct 17, 2017
Merged
FIX: Always update tick labels (fixes #9397)#9452
NelleV merged 1 commit intomatplotlib:masterfromafvincent:fix_incorrect_labels_issue_9397Oct 17, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
anntzer approved these changesOct 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess that'll count as@afvincent's approval of my patch... :-)
45eb1ae
to27fd53a
CompareRebased to fix some PEP8 issues... |
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Force the update ofall the tick labels, even the ones that are not drawn. This addresses the issue#9397 where incorrect labels are returned when some ticks are outside of the displayed range. Please note that the fix idea is@anntzer's one.
PR Checklist
Milestoning it for 2.1.1 as it looks like a minor bugfix to me but feel free to postpone it to 2.2 if somebody thinks that it would be better.(see edit)Supplementary question: should I rebase against the 2.1.x branch?
Edit: re-milestoning it for v2.2, accordingly to what@dstansby suggested in#9397.