Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX: Always update tick labels (fixes #9397)#9452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

afvincent
Copy link
Contributor

@afvincentafvincent commentedOct 17, 2017
edited
Loading

PR Summary

Force the update ofall the tick labels, even the ones that are not drawn. This addresses the issue#9397 where incorrect labels are returned when some ticks are outside of the displayed range. Please note that the fix idea is@anntzer's one.

PR Checklist

  • Has Pytest style unit tests
  • [?] Code is PEP 8 compliant=> Well let's CI confirm ^^
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [?] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way=>@tacaswell Should I add an entry?

Milestoning it for 2.1.1 as it looks like a minor bugfix to me but feel free to postpone it to 2.2 if somebody thinks that it would be better. (see edit)

Supplementary question: should I rebase against the 2.1.x branch?

Edit: re-milestoning it for v2.2, accordingly to what@dstansby suggested in#9397.

@afvincentafvincent added this to thev2.1.1 milestoneOct 17, 2017
@afvincentafvincent modified the milestones:v2.1.1,v2.2Oct 17, 2017
Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess that'll count as@afvincent's approval of my patch... :-)

@afvincentafvincentforce-pushed thefix_incorrect_labels_issue_9397 branch from45eb1ae to27fd53aCompareOctober 17, 2017 03:48
@afvincent
Copy link
ContributorAuthor

Rebased to fix some PEP8 issues...

@NelleVNelleV merged commit4937314 intomatplotlib:masterOct 17, 2017
@QuLogicQuLogic modified the milestones:needs sorting,v2.2.0Feb 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@astrofrogastrofrogAwaiting requested review from astrofrog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

4 participants
@afvincent@anntzer@NelleV@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp