NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Fix instance of 'RendererPS' has no 'tex' member#9448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit intomatplotlib:masterfromcgohlke:patch-15

Dec 1, 2017

Merged

Fix instance of 'RendererPS' has no 'tex' member#9448

tacaswell merged 1 commit intomatplotlib:masterfromcgohlke:patch-15

Dec 1, 2017

Conversation

Copy link

Contributor

cgohlke commentedOct 16, 2017

TheRendererPS.tex function does not appear to be defined anywhere. I assume this is thedraw_tex function? Not sure since this code is around for so many years. Am I missing something?

Fix instance of 'RendererPS' has no 'tex' member

3b60aaf

NelleV requested a review fromtacaswell

October 17, 2017 16:06

Copy link

Member

@cgohlke How did you discover this problem?
I think the patch is correct, but it'd be nice to have regression test, even one that just executes this code and assesses whether it runs or not. Considering how long this has been around, it could just as well be dead code.

Copy link

ContributorAuthor

cgohlke commentedOct 17, 2017

For my recent PRs, I was scanning pylint errors and warnings for potential issues. I do not have a regression test. Given how old this code is and no one noticed (?), maybe this code can be removed?