NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Shadow patch now initializes zorder behind argument patch#9435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dstansby merged 1 commit intomatplotlib:masterfromclintval:cv_shadow_patch_zorder_init

Oct 19, 2017

Merged

Shadow patch now initializes zorder behind argument patch#9435

dstansby merged 1 commit intomatplotlib:masterfromclintval:cv_shadow_patch_zorder_init

Oct 19, 2017

Conversation

Copy link

Contributor

clintval commentedOct 16, 2017•
edited by NelleV
Loading

PR Summary

When initializing apatch.Shadow instance the object inherits the same zorder as the passed patch. This behavior draws the two patches in the same plane. This PR initializes thepatch.Shadow to take the next smallerzorder by default.

This fixes an issue about zorder stacking for Shadow patches referenced here:#9377

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Shadow now initializes zorder behind argument patch

0ce9525

clintval mentioned this pull request

Oct 16, 2017

Shadow applied to a simple patch does not show#9377

Closed

jklymak requested changes

Oct 16, 2017

View reviewed changes

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you write an image test for the correct behaviour? Maybe make sense to merge this and#9426 so the test works? I think the test makes sense in `matplotlib/lib/tests/test_patches.py

Copy link

Contributor

afvincent commentedOct 16, 2017

@jklymak Is animage test really necessary (I think that we are currently trying to avoid as much as possible these kinds of test, that are bloating a bit the git historic)? Couldn't one simply test that after init the z-order of theShadow instance indeed smaller than the z-order of the parent patch?

Copy link

Member

jklymak commentedOct 16, 2017

@afvincent I guess I was also worried about the transform issue in#9426 but maybe both can be finessed without an actual image test? But sure, just checking that the zorders are ordered properly is great!

Copy link

Contributor

anntzer commentedOct 16, 2017•
edited
Loading

I think that the best way is (as mentioned in a few other places) to have an "as if" test: generate figure 1 with the shadow created before the rectangle is added (the previously failing case) and figure 2 with two manually positioned rectangles with the correct zorder and correct positions. It's a bit tricky to write though and I'm fine with taking care of it in#9426 (after this PR gets merged).