Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Text wrapping & better handling of kwargs in pyplot#942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Ooooh, I gotta test this one out. It might solve a problem for me in mplot3d. |
Hmmm, it does not solve the problem I have for mplot3d's scatter() (I get an error message saying that multiple values for 'zs' is given for the invocation as plt.scatter(x, y, zs=z), and I get an error saying that multiple values for 'c' is given for the invocation as plt.scatter(x, y, z). Note that I don't expect the latter to work. |
Are you sure? The following code works for me on this branch, but not for me on master:
|
Huh, must have used the wrong branch or maybe the pyplot.py file didn't rebuild properly? It now works from a clean install. Neat! We probably should make sure that all tests pass and that the examples in the documentation didn't break. |
Should have said, I have done a test run and full documentation build before opening the PR. Seems like there are no concerns so I will merge in ~18 hours (tomorrow morning for me). |
Text wrapping & better handling of kwargs in pyplot
As mentioned in#928, I have some improvements to pyplot which required an improved workflow for generating the pyplot script in the first place. These are those changes.
Firstly, I have added text wrapping in the pyplot module such that no autogenerated line is longer than 80 characters.
Secondly, I have fixed a bug where keyword passing is miss-handled (keywords were previously being passed as positional arguments), which is best demonstrated by the following example:
Resulting in the following error: