NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

TST: Unblock Appveyor build by patching`subprocess`#9395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit intomatplotlib:masterfromKojoley:tst-appveyor-unblock-subprocess

Oct 14, 2017

Merged

TST: Unblock Appveyor build by patching`subprocess`#9395

tacaswell merged 1 commit intomatplotlib:masterfromKojoley:tst-appveyor-unblock-subprocess

Oct 14, 2017

Conversation

Copy link

Member

Kojoley commentedOct 13, 2017•
edited
Loading

closes#9176

Kojoley added OS: Microsoft topic: testing labels

Oct 13, 2017

tacaswell reviewed

Oct 13, 2017

View reviewed changes

.appveyor.yml Outdated

		@@ -95,6 +95,12 @@ install:
		# pytest-cov>=2.3.1 due to https://github.com/pytest-dev/pytest-cov/issues/124
		- pip install -q pytest "pytest-cov>=2.3.1" pytest-rerunfailures pytest-timeout

		# Apply patch to `subprocess` on Python versions > 2 and < 3.6.3
		# https://github.com/matplotlib/matplotlib/issues/9176
		- python -c "import sys; sys.exit((2,) > sys.version_info > (3,6,3))" && (

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't this besys.exit((3,6,3) > sys.version_info > (2,)) ?

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, I wrongly negated the(2,) < sys.version_info < (3,6,3) expression.

tacaswell added this to the2.1.1 (next bug fix release) milestone

Oct 13, 2017

Kojoley force-pushed thetst-appveyor-unblock-subprocess branch from869b84d to6e38b4fCompare

October 13, 2017 19:17

anntzer reviewed

Oct 14, 2017

View reviewed changes

.appveyor.yml Outdated

		# https://github.com/matplotlib/matplotlib/issues/9176
		- python -c "import sys; sys.exit(not (2,) < sys.version_info < (3,6,3))" && (
		curl -sL https://github.com/python/cpython/pull/1224.patch \|
		patch -fsup 1 -d %CONDA_PREFIX% ) \|\| ( set errorlevel= )

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thought only Py3 was affected? Both from my (possibly incorrect) remembering of what used to fail and fromhttps://bugs.python.org/issue30121#msg300658
If it's only a py3 issue then the lower bound should be (3,); if not we can just drop the lower bound (it's not as if we will ever support py1.5 anyways :-)).