Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
On 2.7, run tests on oldest documented supported pytest and pytest-cov.#9317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
pending travis passing on the re-run (error in the qt4 tests that seemed transient).
Added testing of oldest versions of all deps we claim to support. |
Well, looks like we actually don't support pytest 3.0 :-) I'll probably just bump the minimum supported version. |
👍 to bumping pytest version to the minimum we really do support. |
It's actually not clear at all from looking at their changelogs which version of pytest introduced the needed functionality... |
Just keep bumping it until it passes? #experimentalist |
7e305d9 to403dd7bCompareLooks like I got it now. |
I don't see any error with pytest 3.0? The only failure there is brokenness on our part, which is fixedhere in another PR. |
hmmm does travis delete old logs? can't point to it anymore, but basically it was not liking the skipif inhttps://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_backends_interactive.py#L21 |
702cd01 tocf84bb5Comparecf84bb5 to7b4ae79CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 (needs a rebase)
... to make sure that they are indeed supported.Bump to pytest>=3.1 (actually required), dateutil>⩦2.1 (dateutil==2.0is listed on pypi but has no sdist or wheel available).
Going to merge into master since this has two approvals, and also backport to |
There seem to be a conflict, please backport manually |
On 2.7, run tests on oldest documented supported pytest andpytest-cov.Conflicts:.travis.yml - keep version from mastersetupext.py - keep version from v2.1.x
backported to v2.1.x asc72d3fc |
... to make sure that they are indeed supported.
Basically to avoid issues like like#9303.
PR Summary
PR Checklist