Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Restore better error message on std::runtime_error.#9299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

anntzer
Copy link
Contributor

attn@Kojoley#9289 (comment)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@KojoleyKojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@QuLogicQuLogic added this to the2.1.1 (next bug fix release) milestoneOct 6, 2017
@QuLogic
Copy link
Member

Looks like you need to fix the test now.

Copy link
Member

@KojoleyKojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh. You have to placestd::runtime_error handling afterstd::overflow_error because second inherits first andstd::runtime_error catches both.

@anntzer
Copy link
ContributorAuthor

fixed

@tacaswelltacaswell merged commit129403c intomatplotlib:masterOct 7, 2017
@anntzeranntzer deleted the c++-std-runtime_error branchOctober 7, 2017 22:34
tacaswell added a commit that referenced this pull requestOct 8, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dopplershiftdopplershiftdopplershift approved these changes

@KojoleyKojoleyKojoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.

5 participants
@anntzer@QuLogic@dopplershift@Kojoley@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp