Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Throw std::runtime_exception instead of char*.#9289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This should make it easier to debug exceptions falling out of the C++code, as the C++ runtime will print the error message (the `what()` ofthe exception) on its way to aborting the program.Did a regex replace; removed the `char*` handler in CALL_CPP_FULL; andremove a bunch of extra whitespace.
Would prefer@mdboom or@ianthomas23 sign off on this before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm happy with this.
Don't understand the AppVeyor failure.
Hm. |
Oops. New PR coming. |
Backport PR#9289 on branch v2.1.x
This should make it easier to debug exceptions falling out of the C++
code, as the C++ runtime will print the error message (the
what()
ofthe exception) on its way to aborting the program.
Did a regex replace; removed the
char*
handler in CALL_CPP_FULL; andremove a bunch of extra whitespace.
For example, before application of the patch in#9074, the failing code now gives
Should also help with#9244.
PR Summary
PR Checklist