Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Re-organize What's new page#9260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
My rebase is completely un-doable (it organizes the sections), can I just push commits to this branch? |
Sure, go ahead. |
This is more of a bug fix than a new feature
doc/users/whats_new.rst Outdated
| unit. The default string is " ", which preserves the former | ||
| behavior. Additionally, the separator is now present between the value | ||
| and its unit even in the absence of SI prefix. There was formerly a | ||
| bug that was causing strings like "3.14V" to be returned instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
adding bq's here and below will probably help making the difference (extra space) more visible
doc/users/whats_new.rst Outdated
| the API required by a class that is to be used as the ``writer`` in the | ||
| :meth:`matplotlib.animation.Animation.save` method. The existing | ||
| :class:`~matplotlib.animation.MovieWriter` class now derives from the new | ||
| abstract base class. | ||
| Validation of line style rcParams | ||
| --------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
just below, at "strings like ...": would add regular quotes (within the bq's) around "dashed" and "--"
I would lift the subsubsub... headings one level up (perhaps slight rewording) and just drop the "Validation of line style params".
doc/users/whats_new.rst Outdated
| pytest | ||
| ------ | ||
| The automated tests have been switched from `nose` to `pytest`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perhaps link to the respective projects
anntzer commentedOct 5, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
the entry about Renderer._uid in the API changes should be removed (killed by#9070) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Mostly minor stuff; I can't switch branches at the moment or I would just push the changes.
doc/api/api_changes.rst Outdated
| All functionallity from `mpl_toolkits.axes_grid` can be found in | ||
| either `mpl_toolkits.axes_grid1` or `mpl_toolkits.axisartist`. Axes | ||
| classes from `mpl_toolkits.axes_grid` based on `Axis` from | ||
| `mpl_toolkits.axisartist` can be found in `mpl_toolkits.axisartist` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should the first one beaxes_grid? (Plus add period at end).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
functionallity (typo: double l)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed the typo.
I think that this sentence is correct, theAxes sub-classes that used beaxis_grid used tools fromaxisartist, those are now inaxisartist
doc/api/api_changes.rst Outdated
| barh(bottom, width, *, align='center', **kwargs) | ||
| despite behaving as the center in both cases. The methods now take ``*args, **kwargs`` | ||
| is input and are documented to have the primary signatures of:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
s/is/as/
doc/api/api_changes.rst Outdated
| requests that a Delaunay triangulation is calculated, which includes | ||
| `matplotlib.pyplot.tricontour`, `matplotlib.pyplot.tricontourf`, | ||
| `matplotlib.pyplot.tripcolor`, `matplotlib.pyplot.triplot`, | ||
| `mlab.griddata` and `mpl_toolkits.mplot3d.plot_trisurf`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
s/mlab/matplotlib.mlab/ (not sure if that will work)
s/mplot3d/mplot3d.axes3d.Axes3D/
doc/api/api_changes.rst Outdated
| The ``GraphicsContextBase.get_linestyle`` and | ||
| ``GraphicsContextBase.set_linestyle`` methods, which effectively had | ||
| no effect, have been deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"effectively had no effect" sounds a bit redundant.
doc/api/api_changes.rst Outdated
| ``NavigationToolbar2.dynamic_update`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Use :meth:`matplotlib.backend_bases.FigureCanvas.draw_idle` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it'sFigureCanvasBase, but I'm not sure if that's where one wants to be linking.
doc/api/api_changes.rst Outdated
| Remove the delaunay triangulation code which is now handled by Qhull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since I can't comment on it, the other instance ofqhull should be capitalized to match.
@QuLogichttps://git-scm.com/docs/git-worktree is really practical for this case |
doc/users/whats_new.rst Outdated
| :include-source: | ||
| :align: center | ||
| data = {'apples':10, 'oranges':15, 'lemons':5, 'limes':20} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could be PEP8-'ed... (space after colon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also (I guess it's kind of too late for this now...) I amreally surprised that this does not keep key order (dict implicitly maintain key order on 3.6, but even passing an OrderedDict does not help)
doc/users/whats_new.rst Outdated
| @@ -67,83 +116,86 @@ angular ticks have been modified to be parallel to the grid line. It may also | |||
| be useful to rotate tick *labels* to match the boundary. Calling | |||
| ``ax.tick_params(rotation='auto')`` will enable new behavior: radial tick | |||
| labels will be parallel to the circular grid line, and angular tick labels will | |||
| be perpendicular to the grid line (i.e., parallel to the outer boundary.) | |||
| be perpendicular to the grid line (i.e., parallel to the outer boundary). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
just above: "enablethe new behavior"
doc/users/whats_new.rst Outdated
| Annotations now use the default arrow style when setting ``arrowprops={}``, | ||
| rather than no arrow (thenew behavior actually matches the documentation). | ||
| Alternatively, calling ``savefig`` with ``metadata={'creationDate': None}`` | ||
| will omitthetimestamp altogether. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not consistent with the above docs on metadata which say that "Creator" is the only supported key for (e)ps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch, this only applies to the pdf backend.
doc/users/whats_new.rst Outdated
| :: | ||
| ax.xaxis.set_tick_params(which='both', rotation=90) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
just below "Shading can now be toggled etc" to be consistent with the style of other headings
| @@ -453,65 +479,141 @@ figure where the subplots will be created. If ``fig`` is ``None`` (default) | |||
| then the method will use the current figure retrieved by | |||
| :func:`~matplotlib.pyplot.gcf`. | |||
| Example | |||
| ~~~~~~~ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this entry could be merged with the addition of figure.subplots? subplot2grid should be double-bq'ed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
eh, I like the sorting where they are.
doc/users/whats_new.rst Outdated
| Extend ``MATPLOTLIBRC`` behavior | ||
| -------------------------------- | ||
| The environmental variable can now specify the full file path or path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
full file path or directory path? (the sentence is actually not 100% clear although it's not too hard to guess)
| :meth:`matpltolib.cbook.CallbackRegistry.process` suppresses exceptions by default | ||
| :meth:`matplotlib.cbook.CallbackRegistry.process` suppresses exceptions by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a bit below "when it receives AN" (not AND)
DOC: Re-organize What's new page
backported to v2.1.0-doc asa027a02 |
Add more plots and fix some remaining issues from#9259.