NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

include overspilling axes legends in ax.get_tightbbox#9164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

choldgraf merged 1 commit intomatplotlib:masterfromjklymak:fixgettightbox

Oct 21, 2017

Merged

include overspilling axes legends in ax.get_tightbbox#9164

choldgraf merged 1 commit intomatplotlib:masterfromjklymak:fixgettightbox

Oct 21, 2017

Conversation

Copy link

Member

jklymak commentedSep 7, 2017•
edited
Loading

PR Summary

Expandsax.get_tightbbox to include legends.

Now something like

importmatplotlib.pyplotaspltimportnumpyasnpfig,ax=plt.subplots(tight_layout=True)ax.plot(range(10),label="Plot 1")ax.plot(range(10,0,-1),label="Plot 2")ax.legend(loc='center right',bbox_to_anchor=(1.20,0.5))plt.show()

will automatically make room for the legend (viatight_layout).

#9163
#9130

PR Checklist

Code is PEP 8 compliant

jklymak mentioned this pull request

Sep 7, 2017

Legends cut off in Jupyter Notebooks when plotting with %matplotlib notebook command#9163

Closed

jklymak mentioned this pull request

Oct 17, 2017

custom legends example#9451

Merged

afvincent added this to thev2.2 milestone

Oct 17, 2017

Copy link

Contributor

choldgraf commentedOct 17, 2017•
edited
Loading

any idea why appveyor isn't happy?

IMO this is a super useful fix. This is an issue that is constantly coming up. I'd be +1 on backporting to the latest release since it's so simple...

quick other thought: another common "cut off" situation is when you add a figure title that's outside of the figure bounds...is there a straightforward way to capture that situation w/ a similar fix as you've got here?

Copy link

MemberAuthor

jklymak commentedOct 17, 2017

@choldgraf The apveyor prob was just the same apveyor problem everyone has had. I'll rebase and resubmit. Its pretty trivial, and works fine w/ tight_layout...

Copy link

MemberAuthor

jklymak commentedOct 17, 2017•
edited
Loading

@choldgraf This modifies the tight box for an axes. A suptitle isn't attached to an axes, so tight_layout can't know where it is trivially. However,#9082 does handle suptitle.

jklymak requested a review fromcholdgraf

October 17, 2017 19:00

dstansby approved these changes

Oct 19, 2017

View reviewed changes

Copy link

Member

dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 (does this count as an API change? maybe something should go in what's new?)

choldgraf approved these changes

Oct 19, 2017

View reviewed changes

Copy link

Contributor

choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM as it's quite a simple fix, though perhaps@dstansby should merge as they probably know more about the tight-layout machinery than I do

Copy link

MemberAuthor

jklymak commentedOct 19, 2017

Isuppose its an API change. However, I would expect the number of folks usingtight_layout and a legend that is supposed to spill out the axis is vanishingly small since it didn’t work before ;-). The only situation I can see is where someone set up the legend to overspill the axis, it didn’t work when they calledtight_layout, but they left the legend position in there anyway.

Iwill add a what’s new entry, but I don’t think this will break much real-life usage.