Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: document axes-collision deprecation#9132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
DOC: document axes-collision deprecation#9132
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Deprecation of axes collision | ||
| ----------------------------- | ||
| The following is related to the PR #9037 (and incidentally to #9034 too). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you tag these as
:issue:`XXXX`so they link right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Rephrased the mention to use the issue # suggestd by@anntzer and moved it at the end of the entry. Plus now using the:issue: tag.
| Adding an axes instance to a figure by using the same arguments as for | ||
| a previous axes instance currently reuses the earlier instance. This | ||
| behavior has been deprecated in Matplotlib 2.1. In a future version | ||
| (likely 2.3), a *new* instance will always be created and returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I always prefer not indicating the version where removal actually occurs, or is planned to occur: there will be a new note in the changelog when removal actually occurs anyways, and we may as well keep more flexibility this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That was the reason for using "likely" before "2.3" 😈... Well, I simply removed the mention of the version.
3ba3ff8 toad0ef8bCompare@anntzer and@tacaswell, your comments (should) have been fixed in the squashed and rebased version. |
thanks |
Trying to address#9041 by adding an entry in
api_changesabout the deprecation of axes collisions. The text is shamelessly inspired from the deprecation warning message.Tagging it release-critical as#9041 is.