Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Revert "Merge pull request #5754 from blink1073/ipython-widget"#9027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
dopplershift merged 1 commit intomatplotlib:masterfromtacaswell:api_revert_ipywidget_workAug 14, 2017
Merged
Revert "Merge pull request #5754 from blink1073/ipython-widget"#9027
dopplershift merged 1 commit intomatplotlib:masterfromtacaswell:api_revert_ipywidget_workAug 14, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…get"This reverts commit9c100c9, reversingchanges made to6bed1be.The reason for doing this is that ipywidgets is still moving much toofast for Matplotlib to keep up with. The original work done inmatplotlib#5754was done against ipywidgets v4, as of now the final touches are beingput on v7.We are reverting back to our old inject-into-the-DOM method from`nbagg`, which is what is used by `%matplotlib notebook`.For embedding as a 'proper' widget useipympl (github.com/matplotlib/jupyter-wigets) which will release on aschedule that matches the upstream jupyter ecosystem.closesmatplotlib#7695
efiring approved these changesAug 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It works!
dopplershift approved these changesAug 14, 2017
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestOct 23, 2017
These files were moved as part ofmatplotlib#5754 which was reverted inmatplotlib#9027,howevermatplotlib#6370 fixed the paths, but was not also reverted.Putting the js files in sub-directory makes sense, move the filesrather than revert the changes inmatplotlib#6370.fixesmatplotlib#9380
This was referencedJul 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
GUI: nbaggRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit9c100c9, reversing
changes made to6bed1be.
The reason for doing this is that ipywidgets is still moving much too
fast for Matplotlib to keep up with. The original work done in#5754
was done against ipywidgets v4, as of now the final touches are being
put on v7.
We are reverting back to our old inject-into-the-DOM method from
nbagg, which is what is used by%matplotlib notebook.For embedding as a 'proper' widget use
ipympl (github.com/matplotlib/jupyter-wigets) which will release on a
schedule that matches the upstream jupyter ecosystem.
closes#7695
PR Summary
PR Checklist