NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Mask invalid values by default when setting log scale#8836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

NelleV merged 5 commits intomatplotlib:masterfromdstansby:log-mask

Jul 15, 2017

Merged

Mask invalid values by default when setting log scale#8836

NelleV merged 5 commits intomatplotlib:masterfromdstansby:log-mask

Jul 15, 2017

Conversation

Copy link

Member

dstansby commentedJul 3, 2017•
edited
Loading

This supersedes#8056 and#8537. See especially#8537 for previous discussion.

This should fix a few bugs:#8045,#8783

dstansby added3 commits

July 3, 2017 21:26

Change default behaviour of setting logscale to 'mask'

dda42ab

Add logscale mask test

089da7a

Add note to errobar

029fe21

dstansby added the API: changes label

Jul 3, 2017

dstansby added this to the2.1 (next point release) milestone

Jul 3, 2017

Copy link

Member

tacaswell commentedJul 3, 2017

On the bright side our test suite catches the API change!

Add new test image

55863be

Copy link

MemberAuthor

dstansby commentedJul 4, 2017

I'm completely baffled by the travis failure on the .svg figure. I can't reproduce it on OSX or Linux (Python 3.6.1, Inkscape 0.92.1). Might it be because travis is using versioninkscape_0.48.4-3ubuntu2?

dstansby force-pushed thelog-mask branch from4a70bad to55863beCompare

July 4, 2017 20:01

Copy link

MemberAuthor

dstansby commentedJul 4, 2017

Close, but no cigar. Force installing the latest stable build of Inkscape gives an error of 0.001 vs. 0.044 for the default version. Perhaps this is going to need a custom tolerance on the image comparison?

https://travis-ci.org/dstansby/matplotlib/jobs/250114851#L3193 is a branch with latest stable Inkscape

Copy link

Member

tacaswell commentedJul 5, 2017

Can you re-generate the svg and add it to the patch. A while ago we changed how the number is the SVG output were encoded which resulted in similar inkscape version dependent failures.

A feature of the vector outputs is that different text can result in the same image (which is why we test on comparing the rasterizations not the text), but it can lead to small issues like this.