Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Changed normalization in _spectral_helper() to obtain conistent scaling#8582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ng in magnitude_spectrum() and fixed doc string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me - is there any reason we're running our own FFT code and not just using scipy? (I presume because we don't want scipy as a dependency)
As far as I understood it, the reason for having our own implementation is that the FORTRAN code in SciPy is making installation cumbersome under windows. |
1) mlab.py predates scipy and 2) yes, we have a strict rule on notdepending upon advanced packages such as scipy.This rule was originally born of the need to keep the installation assimple as possible, however it has also been a good way to help keepmatplotlib's scope in check. Yes, there are some legacy code where we aredoing some advanced things that we probably shouldn't, but they remain inthe codebase strictly for legacy reasons. It would be hard to remove thatfunctionality now since it has been present for so long. …On Sun, May 14, 2017 at 3:07 PM, Dietrich Brunn ***@***.***> wrote: As far as I understood it, the reason for having our own implementation is that the FORTRAN code in SciPy is making installation cumbersome under windows. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8582 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-HHvQFwHSWD_KuZoQkM1L2JfRrCaks5r51DhgaJpZM4NS3bY> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me 👍
Is there any way to recover the previous behavior? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please add a note tohttps://github.com/matplotlib/matplotlib/tree/master/doc/api/api_changes ?
@tacaswell I added an example to the api_changes on how to obtain the old behavior. I don't think it makes sense to add option to the function, since the original behavior is inconsistent (different window functions make different scalings). |
Thanks@vollbier for all of the work you have been doing on the spectral related code! |
Fixes#8417.
Also a docstring of
axes.magnitude_spectrum()is updated since it has no parameterscaling.