NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Fix % formatting and Transform equality.#8399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dstansby merged 1 commit intomatplotlib:masterfromanntzer:fix-axesstack-formatting-transforms-eq

Apr 12, 2017

Merged

Fix % formatting and Transform equality.#8399

dstansby merged 1 commit intomatplotlib:masterfromanntzer:fix-axesstack-formatting-transforms-eq

Apr 12, 2017

Conversation

Copy link

Contributor

anntzer commentedMar 29, 2017

Use.format(key) instead of% key formatting which fails whenkey
is a tuple (one could also use% (key,) but we may as well use the
more modern option).

TheTransform class doesn't need to override__eq__ as user-defined
classes default to using identity for equality. This also avoids having
to add a__hash__ to these classes to make them hashable (by default,
user-defined classes are hashable, but become unhashable (in Py3) if
they define a__eq__ without defining a__hash__). A more complete
PR should define__hash__ for allTransform subclasses too.

Partial fix for#8395 (a full fix needs to restore hashability of most Transform subclasses).

Fix % formatting and Transform equality.

f5ad81d

Use `.format(key)` instead of `% key` formatting which fails when `key`is a tuple (one could also use `% (key,)` but we may as well use themore modern option).The `Transform` class doesn't need to override `__eq__` as user-definedclasses default to using identity for equality.  This also avoids havingto add a `__hash__` to these classes to make them hashable (by default,user-defined classes are hashable, but become unhashable (in Py3) ifthey define a `__eq__` without defining a `__hash__`).  A more completePR should define `__hash__` for all `Transform` subclasses too.