Just noting here that we're still having a bit of discussion on theoriginal issue for reference.

BTW, the problem with this is that there is no good place in a minimal backend to do this monkeypatching, since not all backends need to initialize aFigureManager (that's the place where GUI backends apply their hack). So for example all non-interactive backends are broken by this measure, since none of them have a figure manager; e.g.:

In [1]: import matplotlibIn [2]: matplotlib.use('pdf')In [3]: import matplotlib.pyplot as pltIn [4]: f = plt.figure()In [5]: plt.plot([1,2])Out[5]: [<matplotlib.lines.Line2D at 0xa1e02ec>]In [6]: f.show()---------------------------------------------------------------------------AttributeError                            Traceback (most recent call last)/home/fperez/ipython/ipython/<ipython-input-6-ffb034f3e6e2> in <module>()----> 1 f.show()AttributeError: 'Figure' object has no attribute 'show'

I've made the hackish fix inthis IPython PR.

I still think that a cleaner solution should be implemented on the mpl side of things for consistency across backends: right now the behavior of a figure object depends on which backend happens to have been active when it was created. That's kind of nasty, I think. But for now,@dwf's problem with IPython should be fixed (assuming the PR doesn't introduce any other problems).

I would be nice to get this in 1.2.

The linked discussion results in the following suggested improvement:

class Figure:    def show(self):        manager = getattr(self.canvas, 'manager')        if manager is not None:            manager.show()# and then define a do-nothing default "def show" for the manager (so backend implementers are aware to target it)class FigureManagerBase:    def show(self):        'raise the figure window and redraw'        pass

A reproducible case:

>>> import matplotlib>>> matplotlib.use('agg')>>> import matplotlib.pyplot as plt>>> plt.plot(range(10))[<matplotlib.lines.Line2D object at 0x102508750>]>>> fig = plt.gcf()>>> fig.show()Traceback (most recent call last):  File "<stdin>", line 1, in <module>AttributeError: 'Figure' object has no attribute 'show'

Agreed. I think we can and should get this in for 1.2.

Attached is an implementation of@pelson's idea.

This is really confusing, but I don't have time to look at it adequately now. Based on the code above, I would conclude that calling fig.show() with a non-gui backend would generate the warning. I think that is the way@pelson reads it also, but it sounds like you are saying this is not correct.

Edit: correction: you are agreeing, but you think the warning is needed. Why?

And if this method is being overwritten by the gui backends, shouldn't that be noted in the docstring?

Confusing!

Yes -- I was agreeing with@pelson.

I think the warning is needed because any time a function is called that has no effect it has the potential to be surprising. ("I'm callingshow, why is nothing showing?") If the user wanted to show a figure in a window, they should be using a GUI backend -- and the warning hopefully points them in that direction.

We certainly can note that the GUI backends override the method -- but I think that belongs in a comment, not the docstring.

To elaborate -- right now if the user calls "show" with a non-GUI backend, they get an exception and that makes it clear that something is wrong. With this change, they get a warning. Perhaps that could be an exception -- but one that's a little more clear than just an AttributeError. But silently doing nothing is IMHO, the worst option of the three.

Will it break anything if we make it an exception. For the backends which don't currently override show, nothing has changed, except there is an "abstract" method which now emits a warning rather than raising an AttributeError. Right?

If thats the case, I would probably favour raising an exception myself.

On 2012/08/20 9:34 AM, Michael Droettboom wrote:

I think the warning is needed because any time a function is called that
has no effect it has the potential to be surprising. ("I'm calling
|show|, why is nothing showing?") If the user wanted to show a figure in
a window, they should be using a GUI backend -- and the warning
hopefully points them in that direction.

plt.show() does nothing when a non-Gui backend is in use. This is by
design.

What I am concerned about is the ability to support code that can be run
interactively or non-interactively.

This evening I should be able to take a closer look; maybe that will
allay my concern.

I took a closer look, and read some of the background, and I still don't see any reason to warn when fig.show() is a no-op, any more than when plt.show() is a no-op.

And why do the gui backends still need to override this? Isn't the new Figure.show() equivalent to what they are doing with the monkeypatch?

Sorry, but it is all still confusing.

I am uncomfortable with makingfig.show() a no-op for some backends. There are already plenty of questions out there along the lines of "why does nothing happen when I doplt.show()?". This could be a good opportunity to raise a custom exception, say aNonInteractiveBackendException, which would be clear, and easy to pythonically handle for general purpose code writing.

What's the concensus here? Should figure.show on a non-GUI backend, do nothing, warn or raise an exception? I'd be interested in@fperez take wrt IPython.

My vote, in order of preference from highest to lowest: [warn, raise, do-nothing]

Could we have a clear explanation of who is expected to use fig.show, and for what purposes? And of my question regarding whether the backends still need to override it?

fig.show is useful if not using the pyplot interface. It seems natural to create a figure object and then show it.

The backends don't set it all to the same thing. Gtk and Qt4, for example, set it to the equivalent offig.canvas.window.show, but TkAgg does something quite different. We could probably refactor and standardize onfig.canvas.show for everything to avoid the monkey-patching of the figure object, but I haven't tested through all the details.

OK, so it is for general use when avoiding pyplot. This fits in with#1125. Good.

Here is a very ugly illustration of my use case for letting fig.show() be a no-op when a non-gui backend is in use:

import sysimport numpy as npimport matplotlibif sys.argv[1] == 'show':    matplotlib.use("gtkagg")    _wait = Trueelse:    matplotlib.use("agg")    _wait = Falsefrom matplotlib.pyplot import subplots, closedef plotter(fig, ax, n):    ax.plot(np.random.rand(n))    fig.savefig("random_%s.png" % n)    fig.show()if __name__ == "__main__":    fig1, ax1 = subplots(1)    plotter(fig1, ax1, 10)    fig2, ax2 = subplots(1)    plotter(fig2, ax2, 20)    if _wait:        print raw_input("waiting...")    close(fig1)    close(fig2)

If fig.show() is a no-op for non-gui backends, this works without requiring that plotter() (which might be in some other module) needing to check what kind of backend is in use, or have some flag passed to it for that purpose.

@efiring: I see the utility of this. The current behavior, of course, is that this throws anAttributeError. I just wonder about the potential for confusion whenfig.show() silently does nothing. It occurs to me that we're talking about different uses cases: mine is at the console and yours is in a library that potentially is doing a bunch of other stuff.

I wonder if it would be too magical to detect if we're at the python/ipython console and warn only then? This would have to be for a direct call of show (i.e. the next stack frame is the repl loop) and not an embedded call of show within a library. Maybe I'm just overthinking.

I think you are over-thinking this. I would find it confusing to have
different behaviors just because I ran something manually versus running
from a script. No, I think a warning message that says how to filter it
would be best.

I've updated this with@WeatherGod's suggestion, which seems like a way to thread this needle.

Alternative: do what we do in matplotlib.use, which is to provide a kwarg to suppress the warning. The rationale is similar, the implementation is similar, and it is much more straightforward than requiring a whole function and a new class to manipulate the warning module.

@efiring: Yes, I guess I like that even better. @WeaterGod: what do you think? I'll implement that if we agree.

Just realized I commented on an old commit...

Looks good to me. Might want to double-check what happens with an ipython notebook, though.

I have to admit, I prefer@efiring 's idea of adding a suppressionkwarg, but this solution is better than nothing at all.

@mdboom: I think the action is on you to decide what your preference is.

I suggest#1192 as a replacement for this PR.

Superceded by#1192.