NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

ENH: try to use unicode charmap before ADOBE_STANDARD in textpath#8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

tacaswell wants to merge1 commit intomatplotlib:masterfromtacaswell:fix_textpath_unicode

Closed

ENH: try to use unicode charmap before ADOBE_STANDARD in textpath#8286

tacaswell wants to merge1 commit intomatplotlib:masterfromtacaswell:fix_textpath_unicode

Conversation

Copy link

Member

tacaswell commentedMar 13, 2017

This will allow a wider range of glyphs to be exported.

Closes#8280

This needs some tests and an understanding of why the adobe mapping was used to begin with.

ENH: try to use unicode charmap before ADOBE_STANDARD in textpath

cb1c72e

This will allow a wider range of glyphs to be exported.Closesmatplotlib#8280

tacaswell added this to the2.1 (next point release) milestone

Mar 13, 2017

tacaswell mentioned this pull request

Apr 2, 2017

Fixed Issue #8068 - SVG encoding#8415

Closed

tacaswell modified the milestones:2.1.1 (next bug fix release),2.1 (next point release)

Aug 13, 2017

tacaswell modified the milestones:2.1.1 (next bug fix release),2.2 (next feature release)

Oct 9, 2017

anntzer requested changes

Dec 2, 2018

View reviewed changes

Copy link

Contributor

anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While working on improving usetex support in mplcairo, I realized why this won't work (at least as is).

In usetex mode, the SVG backend gets a list of (fontpath, glyph-index) from dviread and passes them to textpath to generate the glyph outlines that get embedded into the SVG file. However, the indices in the dvi file (and thus returned by dviread) correspond to the "native" charmap in the font file, which, for pfb fonts (e.g. computer modern), is an Adobe mapping. The Unicode charmaps are actually "fake" charmaps synthesized on-the-fly by FreeType. In particular, they do not include ligatures (which after all do not correspond to Unicode codepoints).
For example, one can trytext(.5, .5, "ff", usetex=True); savefig("/tmp/test.svg") ("ff" is a ligature at position 11 of the "native" charmap); with this PR one gets

/home/antony/src/extern/matplotlib/lib/matplotlib/textpath.py:391: RuntimeWarning: Glyph 11 missing from current font.  glyph0 = font.load_char(charcode, flags=ft2font_flag)

and theff ligature is not included (because, with the PR, one tries instead to load the character at Unicode codepoint 11, which is not a printable character).