Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
TST: fail on missing baseline file#8262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
anntzer commentedMar 10, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
You probably meant to raise that exception. But I wonder whether we even need to bother doing the copy -- why can't we just compare with the image in its original folder (and fail on access if the image is not present)? |
b5e777e
toa4c309e
CompareForce-pushed a fix to raise. That is an interesting question, the copying goes back toa5729a5 with the comment "testing bugfix: don't save test results to site-packages". One nice thing about copying the files is that it puts them (along with the results) next to each other with slightly different names which is something that |
anntzer left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM as a quickfix, but as mentioned in the thread I think some additional refactoring is of order.
The change from a fail to knownfail on missing file come in via3f3991a which I apparently did not review carefully enough, sorry.