Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

TST: fail on missing baseline file#8262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tacaswell
Copy link
Member

The change from a fail to knownfail on missing file come in via3f3991a which I apparently did not review carefully enough, sorry.

@tacaswelltacaswell added this to the2.1 (next point release) milestoneMar 10, 2017
@anntzer
Copy link
Contributor

anntzer commentedMar 10, 2017
edited
Loading

You probably meant to raise that exception. But I wonder whether we even need to bother doing the copy -- why can't we just compare with the image in its original folder (and fail on access if the image is not present)?

@tacaswelltacaswellforce-pushed thetst_fail_on_missing_baseline branch fromb5e777e toa4c309eCompareMarch 10, 2017 21:33
@tacaswell
Copy link
MemberAuthor

Force-pushed a fix to raise.

That is an interesting question, the copying goes back toa5729a5 with the comment "testing bugfix: don't save test results to site-packages".

One nice thing about copying the files is that it puts them (along with the results) next to each other with slightly different names which is something thattools/test_triage.py relies on, but it probably would give a nice speed up (and we can fix test_triage with out too much trouble).

Copy link
Contributor

@anntzeranntzer left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM as a quickfix, but as mentioned in the thread I think some additional refactoring is of order.

@QuLogicQuLogic merged commitc6aebde intomatplotlib:masterMar 13, 2017
@tacaswelltacaswell deleted the tst_fail_on_missing_baseline branchMarch 13, 2017 20:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@KojoleyKojoleyAwaiting requested review from Kojoley

Assignees
No one assigned
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@anntzer@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp