NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Use rounding instead of truncation to calculate the frame size#8250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ngoldbaum wants to merge1 commit intomatplotlib:masterfromngoldbaum:frame-size-round

Closed

Use rounding instead of truncation to calculate the frame size#8250

ngoldbaum wants to merge1 commit intomatplotlib:masterfromngoldbaum:frame-size-round

Conversation

Copy link

Contributor

ngoldbaum commentedMar 9, 2017

This fixes an issue I ran into where the frame sizes were supposed to be adjusted to integers by_adjust_frame_size, but because theframe_size property uses truncation, the vagaries of floating point math means that the frame size adjustment didn't work. Here's a snippet from my debugging session that illustrates the issue:

(Pdb) self.fig.get_size_inches()[1]*self.dpi919.99999999999989

I think it's safe just to use rounding here instead of truncation? Maybe we need to add epsilon somewhere instead if this could cause issues.

Yay floating point math!

use rounding instead of truncation to calculate the frame size

4bb19a3

dopplershift requested changes

Mar 9, 2017

View reviewed changes

lib/matplotlib/animation.py

		@@ -267,7 +267,7 @@ def __init__(self, fps=5, codec=None, bitrate=None, extra_args=None,
		def frame_size(self):
		'A tuple (width,height) in pixels of a movie frame.'
		w, h = self.fig.get_size_inches()
		returnint(w * self.dpi),int(h * self.dpi)
		returnround(w * self.dpi),round(h * self.dpi)