Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Simplify implementation of is_numlike & is_string_like.#7996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| except: | ||
| return False | ||
| return True | ||
| return isinstance(obj, (six.string_types, np.str_)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please addnp.unicode_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah the joys of Py2... fixed.
bdfa250 to6b716cfCompareI half expected this patch to break all our tests… |
See#7795 and#7835 for the motivation. Note that this PR does not actually deprecate either function -- just replaces them by a "saner" implementation (as argued in the issues).