Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX label vertical alignment can now be specified#7970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -18,6 +18,12 @@ values is a single line of python | |||
| See :ref:`customizing-with-matplotlibrc-files` for details about how to | |||
| persistently and selectively revert many of these changes. | |||
| .. note:: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would give this a'YTick alignment' section in the'Tick Label Formatting' section. We don't have completely throw our selves under the bus in the first section. I don't think this needs to be called out in a note, merging it into the paragraph above would be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 on the name and section. Finding a better name was on my todo list.
This patch adds a new rcParams allowing to set label vertical alignment. Thesole reason for the existance of this new parameter is to allow user to resetthe style to before 2.0 for testing purposes.closes#7905
This allows the public classic stylesheet to be 'more' backward compatible
attn @matplotlib/developers |
What is the argument for adding yet another private rcparam (which the codebase will have to keepa round for a while) rather than regenerating the test suite images (which is a one shot thing)? |
Ah, I see, sorry for the noise. |
It's around 350 images to regenerate. It's makes the git repository grow massively :( I'll let@tacaswell give the final word on this. |
For consistency's sake, we should also have an xtick version of this parameter. I am disappointed that we seemed to have updated our baseline images, thereby causing this discrepancy between our classic style used by our tests and the classic style used by our users, but I agree that it would be much more harmful to regenerate these images for such a tiny change. We run the risk of a more serious error during the regeneration process. |
I am still in favor of the extra style sheet and 👍 on doing x as well. |
With the pytest migration, it would be simpler if you rebased on and targetted |
This patch is going to be a mess to apply both on master and v2.0.x |
I am closing this in favor of#8081 : same patch, targetting v2.0.x. |
Uh oh!
There was an error while loading.Please reload this page.
This patch adds a new rcParams allowing to set label vertical alignment. The
sole reason for the existance of this new parameter is to allow user to reset
the style to before 2.0 for testing purposes.
This patch provides a fix to a very pick backward compatibility break. Unfortunately, the
patch that introduces this break also regenerated the test images. This leads to the introduction of a private _test_class stylesheet, corresponding to our current test suite, and a classic stylesheet which is backward compatible.
refs#7905
TODO