Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed GraphicsContextBase linestyle getter#7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
NelleV merged 1 commit intomatplotlib:masterfromKojoley:fix-linestyle-getter
Jan 13, 2017

Conversation

Kojoley
Copy link
Member

Closes#3354

@KojoleyKojoley added this to the2.1 (next point release) milestoneJan 2, 2017
@tacaswell
Copy link
Member

For reference, this has been like this sincee34a333 and has no previous history.

We also do not appear to ever use it internally. All of our backends useget_dashes instead which (mostly) ensures that the dash pattern is the same across all backends (and enables us to scale the pattern with line width).

This needs an API changes note (there may be third-party backends working around this), but given that the current API is obviously problematic (and no one has complained) I do not think it needs a deprecation cycle.

@Kojoley
Copy link
MemberAuthor

GraphicsContextBase.get_linestyle is not used anywhere in mpl code.
GraphicsContextBase._linestyle is used only inGraphicsContextBase.copy_properties and it sets the variable DIRECTLY.
GraphicsContextBase.set_linestyle is used only inone place andoverridden only in wx backend.
There isa TODO entry in pdf backend about_linestyle from 2006 year and I am not sure it makes any sense now.

So I assume it is safe to fix this without deprecation (or even to remove the property).

@anntzer
Copy link
Contributor

If we're going to break backcompat, let's just remove the property?

@tacaswell
Copy link
Member

power cycled to run CI with fixes from master branch to other tests.

@codecov-io
Copy link

codecov-io commentedJan 9, 2017
edited
Loading

Current coverage is 62.52% (diff: 100%)

Merging#7730 intomaster will increase coverage by0.40%

@@             master      #7730   diff @@==========================================  Files           174        174            Lines         56028      56703   +675     Methods           0          0            Messages          0          0            Branches          0          0          ==========================================+ Hits          34805      35453   +648- Misses        21223      21250    +27  Partials          0          0

Powered byCodecov. Last update8279f64...0980bc5

@anntzeranntzer mentioned this pull requestJan 9, 2017
@NelleV
Copy link
Member

LGTM 👍
Thanks@Kojoley

@NelleVNelleV merged commit26a30ce intomatplotlib:masterJan 13, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

5 participants
@Kojoley@tacaswell@anntzer@codecov-io@NelleV

[8]ページ先頭

©2009-2025 Movatter.jp