Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fixed GraphicsContextBase linestyle getter#7730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
For reference, this has been like this sincee34a333 and has no previous history. We also do not appear to ever use it internally. All of our backends use This needs an API changes note (there may be third-party backends working around this), but given that the current API is obviously problematic (and no one has complained) I do not think it needs a deprecation cycle. |
So I assume it is safe to fix this without deprecation (or even to remove the property). |
If we're going to break backcompat, let's just remove the property? |
power cycled to run CI with fixes from master branch to other tests. |
codecov-io commentedJan 9, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Current coverage is 62.52% (diff: 100%)@@ master #7730 diff @@========================================== Files 174 174 Lines 56028 56703 +675 Methods 0 0 Messages 0 0 Branches 0 0 ==========================================+ Hits 34805 35453 +648- Misses 21223 21250 +27 Partials 0 0
|
LGTM 👍 |
Closes#3354