Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix table identation in docs#7710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Remove htmlonly directive which breaks table identation.
Tentative 👍 It seems likely that the line below would not render correctly in the latex/pdf version of the docs (At least when originally added). Before merging this we should probably verify that the docs still build with latex |
Closes#7300 |
codecov-io commentedDec 30, 2016
Current coverage is 62.07% (diff: 100%)@@ master #7710 diff @@========================================== Files 174 174 Lines 56022 56022 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== Hits 34775 34775 Misses 21247 21247 Partials 0 0
|
Unfortunately, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As@QuLogic mentions, this breaks the PDF output and thus cannot be merged.
latex does provide \textcircled (it warns "invalid in math mode" but still works, in local tests...) I would suggest supporting \textcircled in mathtext and deprecating \mathcircled? No point in reinventing our own dialect of latex... |
Hi@akarilimano |
@NelleV, sorry, I'm not sure what I can do here. Any tips? Change to \textcircled everywhere? |
Closing as there is not much we can do without overhauling Sorry@akarilimano 😞 Hopefully we will hear from you again! |
Remove htmlonly directive which breaks table identation as described at#7300
'htmlonly' directive is used only in 17 files in matplotlib docs. As every other usage preceeds some additional information like release date, I belive this to be some sort of typo. But I am not completely sure.