Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove some numpy 1.6 workarounds#7494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -80,22 +61,7 @@ def __init__(self, seq): | |||
| def convert_to_string(value): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you should be able to get rid of this function entirely as all the data gets cast to strings with the np.array(dtype=unicode) call and therefore you can remove the call to convert_to_string. Also, you should then remove the test functions from category.py
codecov-io commentedNov 21, 2016
Current coverage is 62.00% (diff: 100%)@@ master #7494 diff @@========================================== Files 109 173 +64 Lines 46636 55999 +9363 Methods 0 0 Messages 0 0 Branches 0 0 ==========================================+ Hits 31043 34720 +3677- Misses 15593 21279 +5686 Partials 0 0
|
We should wait for appveyor on this one. |
Appveyorfinally got there… The failure seems unrelated.@tacaswell should we merge this? |
Partiallyfixes#7484