Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make hatch colour an rcParam.#7415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
efiring merged 1 commit intomatplotlib:v2.xfromQuLogic:hatch-colour
Nov 7, 2016
Merged

Conversation

QuLogic
Copy link
Member

This turned out easier than I expected because I just had to follow the same work as#6198. As withhatch.linewidth, there is no API to do this, only the rcParam.

Not sure if I should add an explicit test, some other tests kind of implicitly test this stuff (as seen from the updated images.)

Fixes#7166. Also, partially implements#7059.

@QuLogicQuLogic added Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. API: default changes topic: rcparams labelsNov 5, 2016
@QuLogicQuLogic added this to the2.0 (style change major release) milestoneNov 5, 2016
@efiring
Copy link
Member

You could add a test based on a simplified version of the example in#7166, so that the legend would be tested.

@QuLogic
Copy link
MemberAuthor

I added a test based on@dopplershift's shortened test in#7166, which I think basically covers the path hit by legends.

Interestingly, it isn't broken in PDF or SVG because they determine the colour in some other way somehow. In fact, there's even a testtest_hatching_legend for PDF intest_backend_pdf.py...

@QuLogic
Copy link
MemberAuthor

Hmm, just realized the PDF is broken when usingRectangle without an explicit edge colour, so I must have missed one more place.

@QuLogic
Copy link
MemberAuthor

QuLogic commentedNov 7, 2016•
edited
Loading

On closer inspection, that may be a bug in evince, as it appears fine in pdf.js, inkscape and convert/imagemagick.

Copy link
Contributor

@dopplershiftdopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me (given that this follows the stuff for hatching line width).

@QuLogicQuLogic changed the titleMake hatch colour an rcParam.[MRG+1] Make hatch colour an rcParam.Nov 7, 2016
@QuLogicQuLogic changed the title[MRG+1] Make hatch colour an rcParam.[MRG] Make hatch colour an rcParam.Nov 7, 2016
@efiringefiring merged commit41f4e37 intomatplotlib:v2.xNov 7, 2016
@efiringefiring changed the title[MRG] Make hatch colour an rcParam.Make hatch colour an rcParam.Nov 7, 2016
@QuLogicQuLogic deleted the hatch-colour branchNovember 7, 2016 21:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dopplershiftdopplershiftdopplershift approved these changes

Assignees
No one assigned
Labels
API: default changesRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.topic: rcparams
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@efiring@dopplershift
[8]ページ先頭
©2009-2025 Movatter.jp