Oct 24, 2016 · Oct 25, 2016 · Nov 1, 2016 · Nov 1, 2016 · Nov 1, 2016 · Nov 1, 2016
diff --git a/lib/matplotlib/tests/test_figure.py b/lib/matplotlib/tests/test_figure.py
 import six
 from six.moves import xrange

 from nose.tools import assert_equal, assert_true
 from nose.tools import assert_equal, assert_true, assert_raises
 from matplotlib import rcParams, figure
 from matplotlib.testing.decorators import image_comparison, cleanup
 from matplotlib.axes import Axes

 @cleanup
 def test_stack_remove():
    '''
    Before fixing the bug, doing the following will give you following error:
    >>> a.add('123',plt.figure().add_subplot(111))
    Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
    File "/usr/lib/pymodules/python2.7/matplotlib/figure.py", line 120, in
    add
      Stack.remove(self, (key, a_existing))
    File "/usr/lib/pymodules/python2.7/matplotlib/cbook.py", line 1343, in
    remove
      raise ValueError('Unknown element o')
    ValueError: Unknown element o
    '''
    key = '123'
    a = figure.AxesStack()
    a.add(key, plt.figure().add_subplot(111))
    assert_raises(KeyError, a.add, key, plt.figure().add_subplot(111))
    key = '123'
    axes = plt.figure().add_subplot(111)
    a.add(key, axes)
    # Verify some things
    assert_raises(KeyError, a.add, key, plt.figure().add_subplot(111))
    assert_equal(a._elements, [(key, (1, axes))])


 if __name__ == "__main__":
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,7 +4,7 @@
		import six
		from six.moves import xrange

		from nose.tools import assert_equal, assert_true
		from nose.tools import assert_equal, assert_true, assert_raises
		from matplotlib import rcParams, figure
		from matplotlib.testing.decorators import image_comparison, cleanup
		from matplotlib.axes import Axes
Expand DownExpand Up		@@ -219,24 +219,13 @@ def test_figaspect():

		@cleanup
		def test_stack_remove():
		'''
		Before fixing the bug, doing the following will give you following error:
		>>> a.add('123',plt.figure().add_subplot(111))
		Traceback (most recent call last):
		File "<stdin>", line 1, in <module>
		File "/usr/lib/pymodules/python2.7/matplotlib/figure.py", line 120, in
		add
		Stack.remove(self, (key, a_existing))
		File "/usr/lib/pymodules/python2.7/matplotlib/cbook.py", line 1343, in
		remove
		raise ValueError('Unknown element o')
		ValueError: Unknown element o
		'''
		key = '123'
		a = figure.AxesStack()
		a.add(key, plt.figure().add_subplot(111))
		assert_raises(KeyError, a.add, key, plt.figure().add_subplot(111))
		key = '123'
		axes = plt.figure().add_subplot(111)
		a.add(key, axes)
		# Verify some things
Copy link Member QuLogicNov 2, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Is something supposed to come after this? Copy link ContributorAuthor JunTanNov 2, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. no, sorry , it should come before the assertion. Copy link Contributor trphamDec 6, 2016• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Should the comment be more specific?
		assert_raises(KeyError, a.add, key, plt.figure().add_subplot(111))
		assert_equal(a._elements, [(key, (1, axes))])


		if __name__ == "__main__":
Expand Down