Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Convert a few test files to Pytest#7318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
NelleV merged 4 commits intomatplotlib:masterfromQuLogic:pytest-yield
Oct 22, 2016

Conversation

QuLogic
Copy link
Member

This limited conversion of tests serves two purposes: 1) see how useful nose2pytest is; 2) fix the warnings about yield-based fixtures. Note that because of the conversion toparametrize, these files can no longer be run using nose (liketest_category.py.)

This PR is going to conflict with#7316, so don't merge this one until that's inmaster too.

@QuLogicQuLogic added this to the2.1 (next point release) milestoneOct 21, 2016
@Kojoley
Copy link
Member

Isnp.testing.assert_equal can be freely replaced with== operator?

@QuLogic
Copy link
MemberAuthor

In the changed lines, it's only comparing two numbers; I'm not sure about the general case.

@QuLogic
Copy link
MemberAuthor

QuLogic commentedOct 22, 2016•
edited
Loading

Oh, I missed the otherfrom numpy.testing import assert_equal intest_animation.py. In that file, all the assertions are against simple Python types that should Just Work, except the oneFigure comparison. But I don't think NumPy does anything special for it.

Copy link
Member

@KojoleyKojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@NelleVNelleV merged commit73ed804 intomatplotlib:masterOct 22, 2016
@QuLogicQuLogic deleted the pytest-yield branchOctober 22, 2016 20:46
@rcomerrcomer mentioned this pull requestOct 16, 2022
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@KojoleyKojoleyKojoley approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@Kojoley@madphysicist@NelleV
[8]ページ先頭
©2009-2025 Movatter.jp