Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Caching the results of Transform.transform_path for non-affine transforms#723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
753c9a2c4ceacebf4dd974c88a6dc0884771b1b340e9cc98ec898bdfa81545cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -657,9 +657,9 @@ def draw_gouraud_triangle(self, gc, points, colors, trans): | ||
| writer.start(u'defs') | ||
| for i in range(3): | ||
| x1, y1 =tpoints[i] | ||
MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. This bug came out in the pcolor test (the pcolor was not in the correct place). I don't understand how it wasn't failing before, but the fact that the bug has been highlighted by this PR is a good sign. | ||
| x2, y2 =tpoints[(i + 1) % 3] | ||
| x3, y3 =tpoints[(i + 2) % 3] | ||
| c = colors[i][:] | ||
| if x2 == x3: | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -10,17 +10,17 @@ def test_figure_label(): | ||
| plt.close('all') | ||
| plt.figure('today') | ||
| plt.figure(3) | ||
| plt.figure('tomorrow') | ||
| plt.figure() | ||
| plt.figure(0) | ||
| plt.figure(1) | ||
| plt.figure(3) | ||
| assert_equal(plt.get_fignums(), [0, 1, 3, 4, 5]) | ||
| assert_equal(plt.get_figlabels(), ['', 'today', '', 'tomorrow', '']) | ||
| plt.close(10) | ||
| plt.close() | ||
| plt.close(5) | ||
| plt.close('tomorrow') | ||
| assert_equal(plt.get_fignums(), [0, 1]) | ||
| assert_equal(plt.get_figlabels(), ['', 'today']) | ||
| @@ -33,7 +33,8 @@ def test_figure(): | ||
| ax.set_title(fig.get_label()) | ||
| ax.plot(range(5)) | ||
| # plot red line in a different figure. | ||
| plt.figure('tomorrow') | ||
| plt.plot([0, 1], [1,0], 'r') | ||
| # Return to the original; make sure the red line is not there. | ||
| plt.figure('today') | ||
| plt.close('tomorrow') | ||
MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I was getting a failing test here because I was comparing the "tomorrow" figure rather than the "today" one. I assume this is related to dictionary ordering of figures, but I don't know for sure. | ||