Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Doc organize axes docs#7176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This: - makes the axes_api page a collection of tables which are grouped reasonably - gives each method it's own web page
http://tacaswell.github.io/matplotlib/api/axes_api.html is what it looks like now. |
Wow! What an improvement! |
| Axes.grid | ||
| Axes.get_axis_bgcolor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we keep the documentation of deprecated methods in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The way this is currently working, these are what is triggering the auto-generate sub-pages to be created. If we do not include these here then these methods are not documented at all.
Maybe move all the deprecated methods to 'Deprecated' section at the bottom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think that'd be nice, thought as long as these are clearly documented as deprecated (which they are), I am fine with how it is right now.
| Axes.get_default_bbox_extra_artists | ||
| Axes.get_transformed_clip_path_and_affine | ||
| Axes.has_data | ||
| Axes.hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe this is the time to add a "Future Deprecation Warning" to the docstring in view of#3070
If the first line ends in '::', automsummary generates invalid rst
- remove identical code in YAxis and XAxis, move to Axis - add abstract methods on Axis and Tick to make documenting easier
I took a stab at doing the Axis and Tick API as well. http://tacaswell.github.io/matplotlib/api/axis_api.html I think I am going to write a sphinx extension to generate the 'inherited from Artist' sections. Generated the list of methods / attributes via forninsorted(list(set(dir(maxis.Axis))-set(dir(matplotlib.artist.Artist)))):print('Axis.'+n)ifn[0]!='_'elseNone |
There is probably a better way to get this, but this is effective.Code used to generate this list:def _recursive_subclasses(cls): "Return all subclasses (and their subclasses, etc.)." # Source:http://stackoverflow.com/a/3862957/1221924 return (cls.__subclasses__() + [g for s in cls.__subclasses__() for g in _recursive_subclasses(s)])' '.join(sorted(['.'.join((_.__module__, _.__name__)) for _ in _recursive_subclasses(matplotlib.artist.Artist)]))
| =========== | ||
| .. inheritance-diagram:: Tick Ticker XAxis YAxis XTick YTick | ||
| :private-bases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a reason for not having the inheritance diagramalways at the top (preferable to me) oralways at the bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because I thought it went better at the top inArtist and better at the bottom here. The reason for that is that I would expect users to frequently directly use theAxis classes, but not theTick classes, hence I put the diagram at the bottom. Having now written out this justification, that makes me think thatAxis andTick should get their own pages.
tacaswellSep 27, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
And I now see this is really at the top so I am not sure what I was remembering...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this could be moved to the bottom for all figures.
Opening a bug#7190.
I'll merge this PR in 48hours unless someone has major complaints or updates the PR with new information. |
Thank you@tacaswell ! That's a great improvement on our documentation. |
Note: those changes should also be added to master. |
WillClaudeHolmes commentedMar 1, 2017
@tacaswell, I want to say a big Thank-you for this. I am new to using matplotlib, and I was very confused about how it worked and how to use it. Before this update, I had tried to figure out the object oriented side, but I had little success. It is very understandable now. I am teaching a course in which the students use matplotlib, and this documentation improvement is a big help to me in my course. - Thanks. |
No description provided.