Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix read mode when loading cached AFM fonts#6898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
WeatherGod merged 1 commit intomatplotlib:masterfromzblz:afm-bytes
Aug 4, 2016

Conversation

zblz
Copy link
Member

@zblzzblz commentedAug 3, 2016

This fixes a typo to read cached AFM fonts as a byte string, as needed by the AFM class inafm.py. This bug is triggered when testing PR#5161.

cc:@mdboom

@WeatherGod
Copy link
Member

Indeed, reading through afm.py, it looks like it expects all of the reads to return bytestrings given that it does comparisons against literal byte-strings.

@WeatherGodWeatherGod merged commitf3b6c4e intomatplotlib:masterAug 4, 2016
@WeatherGod
Copy link
Member

This piqued my interest a bit, and I noticed that we are inconsistent with how we are opening the AFM files. Grepping through reveals a few more non-binary open() calls. Would you like to fix those, too?

@WeatherGod
Copy link
Member

actually, looks like that was the only one, although the one in font_manager.py could benefit from context manager. I'll backport just this.

WeatherGod added a commit that referenced this pull requestAug 4, 2016
Fix read mode when loading cached AFM fonts
@WeatherGod
Copy link
Member

Backported to v2.x via08e2520.

@QuLogicQuLogic added this to the2.0 (style change major release) milestoneAug 4, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@zblz@WeatherGod@mdboom@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp