I may have to spin off a PR on supporting both pytest and nosetest on appveyor/travis if I ever want my tests to pass again - help@Kojoley?

I may have to spin off a PR on supporting both pytest and nosetest on appveyor/travis if I ever want my tests to pass again.

Unfortunately, yes.

It is nice to hear that there is a demand in pytest, and I am sorry for my slowness.
I am close to finish with pytest support, but currently there is a major issue in matplotlib that prevents running pytest with xdist (I have not opened issue for it yet, but I am working on solution).
Anyway I think nose should live for some time with pytest until we are sure that there are no false positives.

You can rebase on top of#6730 for pytest support (but it is a bit out of sync, and you need to remove-n $PROC from.travis.yml to disable xdist).

I would like to keep this PR mergeable independent of the pytest PR

@Kojoley You are making more progress on this in the last few weeks than we have made in the last ~ year

then what should I do? I'd rather not have to rewrite all my tests only to rewrite them again, but travis and appveyor won't work with them.

@Kojoley does it make sense to factor out just the py.test & nosetest can both run stuff out of your PR into a separate pull request? I don't want to step on your toes/your PR, but it also may make it easier for other people to adopt py.test in their testing and that not have to wait on full py.test conversion.

maybe pull the tests out, merge this to master with no CI (but running the tests locally), and the put a PR on top of#6730 adding the tests there?

Ugh, 'specially as this will only get worse as I write more tests and my coverage will sink really badly. I really think a relatively small PR that just lets nose and pytest work together might be a better solution unless@Kojoley has an argument against.

maybe pull the tests out, merge this to master with no CI (but running the tests locally), and the put a PR on top of#6730 adding the tests there?

I agree. We can comment outthis line or make a new list of pytest only tests.

my coverage will sink really badly

You can still look at the coverage locally.

I don't want to step on your toes/your PR, but it also may make it easier for other people to adopt py.test in their testing and that not have to wait on full py.test conversion.

My primary goal is to make current test suite both nose & pytest compatible with minimal changes. Just do not useraise KnownFailureTest (I should separate PR forknownfailed function from#6730) and it will work with pytest without changes.

or make a new list of pytest only tests.
I vote for doing that. Also I really really don't want to have to separate my tests from my code. So is their go ahead from you to spin off a PR just for running both nose and py.test?

Just do not use raise KnownFailureTest
already doing that

So is their go ahead from you to spin off a PR just for running both nose and py.test?

It will be in the same PR. I have just temporary disabled nose because otherwise travis and appveyor will run hundred times and spend hours of my life, forcing me to wait for nose while the results does not matter, because all the places that touches nose already tested many times and I want simply know is it all right with pytest or not.

It will be in the same PR.

I think we may be on different pages here. I'm proposing really small PR that just adds support for py.test (nose can still do it's thing) that can hopefully be merged into master fairly quickly. My reason for proposing it is lets people like me write py.test code without having to wait on the full conversion PR getting merged in.

without having to wait on the full conversion PR getting merged in

PR#6730 is only about pytest compatibility with current test suit. It will not growth beyond that. The full conversion is something that I do not expect in the near future.

I think we can do following thing:

• I will prepareAdd Py.test testing framework support #6730 ASAP with just single-threaded support and pytest-only tests filter implementation
• You will rebase this PR on top of it just for check
• If all is ok, mergeAdd Py.test testing framework support #6730 to master, rebase this PR on top of master and merge

But I should warn you about unexpected problems. I really hope#6899 is the last stopper for pytest, but I cannot guarantee this. So if you can wait until weekend with this PR I think it will be the best choice.

Sounds good to me, and can totally wait on the weekend. Thanks

@story645 What is going on with this branch? This mostly rebases cleanly on to current master (see thecategory branch on my fork).

Waiting on#6730 , or does#6920 supercede that@Kojoley

No,#6920 does not supercede#6730.

@story645 please remove the test fromdefault_test_modules var.

Passes travis mostly 'cause this new code is no longer tested as part of this PR. But, all these tests are in#6934 anyway.

@story645 this needs a rebase (again). I suspect it is in the travis config files.

Yup, travis and appveyor and the like 'cause of#6730, updated now.

Pretty sure coverage failure isn't my fault since coverage is up/neutral on the files that are part of this PR.

I have opened a PR#6974 for the issue