Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix for PyQt5.7 support.#6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:pyqt57-fix
Jul 31, 2016
Merged

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedJul 29, 2016
edited
Loading

Just getting rid of a slot with an incorrect signature (for which
PyQt5.7 is more strict).

Tested on PyQt5.6.1 and 5.7, PyQt4.11.4, PySide 1.2.4.

cf#6853.
@tacaswell you already suggested the correct fix a year ago :) (#4894 (comment))

Given that without this fix, matplotlib doesn't work at all with PyQt5.7, I'm milestoning to 2.0; this should probably also be backported to 1.5.3 (1.5.2 if it gets retagged).

Just getting rid of a slot with an incorrect signature (for whichPyQt5.7 is more strict).Tested on PyQt5.6.1 and 5.7, PyQt4.11.4, PySide 1.2.4.
@anntzeranntzer added this to the2.0 (style change major release) milestoneJul 30, 2016
@tacaswell
Copy link
Member

How did you track down that comment?

@tacaswelltacaswell merged commitb80563f intomatplotlib:masterJul 31, 2016
tacaswell added a commit that referenced this pull requestJul 31, 2016
Fix: bad slot signature for Qtcloses#6853
@tacaswell
Copy link
Member

backported to v2.x as6ab5475

@anntzer
Copy link
ContributorAuthor

git blame to see which PR that line came from...

@anntzeranntzer deleted the pyqt57-fix branchJuly 31, 2016 04:02
@tacaswelltacaswell mentioned this pull requestJul 31, 2016
@massimovassalli
Copy link

Hi,
I went into this issue after installing Qt 5.7 and I was unable to work around it. I cloned the current master branch and installed it, but I still get the error. Being quite basic with git, I'm not able to understand which is the release version this master branch relates to: is it 1.5.2 (for which the issue seems to be unsolved) or 1.5.3 (for which it should be) ?
Thanks for any hints,
Massimo

@efiring
Copy link
Member

The 1.5 line is nearing its end. Apart from one last bugfix release, which will be 1.5.3, the line of development goes to 2.x, for which a 2.0 release is anticipated quite soon, and then master, which will be the origin of an eventual 2.1 release--but not soon. The fix in this PR is in master and in 2.x, so if you installed master you should have it. It sounds like it should be backported to 1.5.3. The immediate question, though, is why you are still getting the error if you have installed master. Is it possible that you are seeing a similar error, but not exactly the same one? Or that the python you are using is not the one into which mpl master was installed?

@massimovassalli
Copy link

Hi,
I solved it. I messed up the environment so that python3 was still using the pip3 version I previously installed, which is at 1.5.2 version. I uninstalled it so that now the interpreter correctly sees the 2.0-based version ( 2.0.0b3+2000.g22aa800 ) and my loved tool matplotlib is again working with my preferred backend, qt5.
Thank you,
Massimo

@anntzer
Copy link
ContributorAuthor

Actually, I now think that this issue is annoying enough to warrant a bugfix release asap (say 1.5.2.1 and possibly 2.0b4, respectively based on 1.5.2 and 2.0b3, withonly this additional patch in), except if the next releases are planned forvery soon.

@tacaswell
Copy link
Member

there is a (sadly) growing list of things to backport to a 1.5.3

@rwarren
Copy link

I'm seeing this problem with matplotlib 1.5.2, which is the current version that installs withpip install matplotlib for python 2.7.

tacaswell added a commit that referenced this pull requestSep 8, 2016
Fix: bad slot signature for Qtcloses#6853
@tacaswell
Copy link
Member

backported to 1.5.x as3d2872e

@QuLogicQuLogic modified the milestones:v1.5.x,2.0 (style change major release)Sep 9, 2016
@rmlopes
Copy link
Contributor

rmlopes commentedOct 27, 2016
edited
Loading

I just synced my fork with master, and now I have this problem as well, after a bunch of gtk warnings. Apparently it should not be happening anymore. The version showsmatplotlib==2.0.0b1+1895.g391198e, and theoutput file.

In the notebook it works fine though.

@tacaswell
Copy link
Member

@rmlopes391198e is the tip of your PR (which has stalled, sorry about that!), which was forked before this fix was merged.

@rmlopes
Copy link
Contributor

Thanks, how can I fix it? rebase again?

@tacaswell
Copy link
Member

@rmlopes Yes, rebase + force push should fix this.

@MichaelClerx
Copy link

MichaelClerx commentedMay 4, 2017
edited
Loading

Could it be that I'm seeing the same error under Fedora 25?

python-qt5.x86_64                            5.7-4.fc25python2-matplotlib-qt5.x86_64                1.5.2-0.2.rc2.fc25

@tacaswell
Copy link
Member

Yes, you have a version of Matplotlib that pre-dates this fix (went out the door in 1.5.3).

@MichaelClerx
Copy link

Ah, so not backported to 1.5.2.x then I suppose?

@jenshnielsen
Copy link
Member

There is no 1.5.2.x Matplotlib has at most 3 release levels. The official releases of the 1.5.x series were: 1.5.0, 1.5.1, 1.5.2 and 1.5.3. Anything else is done by fedora maintainers. They may chose to backport patches to their packages but that is completely up to them.

@anntzeranntzer mentioned this pull requestSep 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.3
Development

Successfully merging this pull request may close these issues.

10 participants
@anntzer@tacaswell@massimovassalli@efiring@rwarren@rmlopes@MichaelClerx@jenshnielsen@mdboom@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp