Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
explicitly select cell after figure on shift-enter#6752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
rather than triggering select-next,which may be an arbitrarily other cell
@SylvainCorlay Does this need to be ported to |
This was referencedJul 19, 2016
tacaswell added a commit that referenced this pull requestSep 8, 2016
FIX: explicitly select cell after figure on shift-enter
backported to 1.5.x asf9d696e |
physinet added a commit to physinet/matplotlib that referenced this pull requestOct 31, 2018
Commit86ac6ce undid the changes from commitd527799 to change the behavior of shift-enter in Jupyter notebook, as discussed inmatplotlib#1124,matplotlib#4758, andmatplotlib#6752.With the changes here, shift-enter now selects the next cell, executes it, and then selects the following cell.
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rather than triggering select-next via
jkeystroke without checking what cell is currently selected. Further, if the user has custom shortcuts hittingjcan trigger any arbitrary action.Fixes the apparent shift-enter skipping a cell discussed injupyter/notebook#1124.
closesjupyter/notebook#1124
cc@tacaswell