Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Py.test testing framework support#6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 10 commits intomatplotlib:masterfromKojoley:improve-tests
Aug 23, 2016

Conversation

Kojoley
Copy link
Member

This PR is part of preparation for migration topytest

@Kojoley
Copy link
MemberAuthor

Missed several other places, will update PR soon.

@tacaswelltacaswell added this to the2.1 (next point release) milestoneJul 12, 2016
@story645
Copy link
Member

Is this a continuation of#5325?

@tacaswell
Copy link
Member

Also, please be aware ofhttps://github.com/matplotlib/pytest-mpl

@KojoleyKojoley changed the titleMove out from nose specific things in testsAdd Py.test testing framework supportJul 23, 2016
@KojoleyKojoleyforce-pushed theimprove-tests branch 20 times, most recently frome8a4d60 to32fc6b9CompareJuly 28, 2016 16:09
@KojoleyKojoleyforce-pushed theimprove-tests branch 2 times, most recently from30bbacc to0b30109CompareJuly 31, 2016 10:57
@KojoleyKojoleyforce-pushed theimprove-tests branch 2 times, most recently fromc3dc84e to6931c9eCompareAugust 4, 2016 10:24
…test``do_test` function variables are changed by loop where function was creates.It will work as you expect only if you call yielded function immediately.
@KojoleyKojoleyforce-pushed theimprove-tests branch 2 times, most recently from745d683 to391e981CompareAugust 21, 2016 11:58
@Kojoley
Copy link
MemberAuthor

Pytest 3.0 released with this change:

yield-based tests are considered deprecated and will be removed in pytest-4.0.

😕

The bug will not be fixed in pytest because generator functions aredeprecated since pytest 3.0 release.
@Kojoley
Copy link
MemberAuthor

Coverage problem is because ofif [[ $NOSE_ARGS="--with-coverage" ]]; then in.travis.yml. The expression should be either[ a=b ] or[[ a==b ]].

@Kojoley
Copy link
MemberAuthor

PR is now ready for review and merge.

Key notes:

story645 reacted with thumbs up emoji

@tacaswell
Copy link
Member

It looks like pytest is finding 5 more tests than nose so that is probably a victory.

It looks like pep8 is being run by pytest on travis, but not on appveyor, but that is ok for now.

There is a big CI hit time wise for this and we will have to (soon) pick some of the nose builds to drop.

@tacaswelltacaswell merged commit84f471e intomatplotlib:masterAug 23, 2016
@Kojoley
Copy link
MemberAuthor

It looks like pep8 is being run by pytest on travis, but not on appveyor, but that is ok for now.

I made this intentionally because we have separated pep8 only build on travis so there is no need to run them on all appveyor builds. Or I was wrong?

@tacaswell
Copy link
Member

If anything pep8 should be skipped by travis pytest build. According to the handy output, it is only 45s which is not a big deal on top of our total runtime.

@jenshnielsen
Copy link
Member

As far as I remember the main reason for splitting pep8 out in a separate build is not so much runtime but making it simpler to spot failures that are due to pep8 only

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

6 participants
@Kojoley@story645@tacaswell@jenshnielsen@QuLogic@mdboom

[8]ページ先頭

©2009-2025 Movatter.jp