Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Assume that tickers respect view limits.#6647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@anntzer
Copy link
Contributor

Tickers may return positions epsilon-outside of the view limits and we
don't want to drop them.

Fixes#6641.

Tickers may return positions epsilon-outside of the view limits and wedon't want to drop them.
@anntzer
Copy link
ContributorAuthor

I cannot reproduce the test_simplification failures locally -- can someone have a look?
test_markevery_linear_scales_zoomed fails locally even though there is no visible difference in the images acoording to the test triage tool; I guess this may be due to an extra tick on the edge, in which case I'll just generate a new reference image. Here too, another pair of eyes may be helpful.

@QuLogicQuLogic added this to the2.0 (style change major release) milestoneJun 27, 2016
@QuLogic
Copy link
Member

They are mostly due to the tick on the edge, though curiously only for the svg tests:

  • test_simplification.test_diamond:
    clipping_diamond_svg-failed-diff
  • test_simplification.test_clipping:
    clipping_svg-failed-diff
  • test_axes.markevery_linear_scales_zoomed
    markevery_linear_scales_zoomed_svg-failed-diff

@QuLogic
Copy link
Member

Looking at the markevery_linear_scales result, it seem like the svg->png conversion is a bit buggy. It appears as if the axes line is partially transparent (maybe 0.5 pixel wide, sort of thing?), so the ticks "bleed through". But if you look at the svg in eog, the axes is black, so there reallyshouldn't be a difference.

@anntzer
Copy link
ContributorAuthor

Can you generate the new baseline images (and perhaps open a new issue w.r.t. the conversion)? As mentioned above the tests pass fine locally for me, so I guess I can't generate them...

@tacaswell
Copy link
Member

Tickers do not have to respect the view limit and are allowed to return ticks which are not visible.

@anntzer
Copy link
ContributorAuthor

Do you have a counter-example? Can we change the specification so that tickersdo have to respect the view limits? (This issue is a perfect example why such a requirement would be helpful...)

@efiring
Copy link
Member

I think that the idea here is that tickers are used in the classic autoscaling mode todetermine the view limits. When called to actually get the ticks, however, I think they are called with the view limits after this autoscaling has already been done, and with the resulting view limits, so they should be able to return only the ticks that respect those limits. How all the tickers actually behave is another question.

@anntzer
Copy link
ContributorAuthor

anntzer commentedJun 27, 2016
edited
Loading

Actually there seems to be another point where ticks are cropped to the actual limits:https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/axis.py#L1000
Not thatsmart_bounds seem to be mentioned anywhere in the docs... another good thing to get rid of?

@QuLogic
Copy link
Member

Replaced by#7042.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@anntzer@QuLogic@tacaswell@efiring@mdboom

[8]ページ先頭

©2009-2025 Movatter.jp