Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update make.py#6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jenshnielsen merged 2 commits intomatplotlib:masterfromklonuo:patch-1
Jun 13, 2016
Merged

Update make.py#6530

jenshnielsen merged 2 commits intomatplotlib:masterfromklonuo:patch-1
Jun 13, 2016

Conversation

klonuo
Copy link
Contributor

Referencing#6527, these changes provide:

  • fix for symlink exception on Windows
  • no need for rebuilding matplotlib from source

Referencingmatplotlib#6527, these changes provide: - fix for symlink exception on Windows - no need for rebuilding matplotlib from source
@tacaswelltacaswell added this to the2.0 (style change major release) milestoneJun 3, 2016
@tacaswell
Copy link
Member

@efiring I think this should fix your issue building the docs?

@jenshnielsen
Copy link
Member

Im a bit worried about coping the users default rc file for generating the documentation. This can result in the documentation unintentionally being generated with a non default style. Would it not be better to refactor the code out from setup.py that generates the rc file from the template and call that as part of make.py?

@tacaswell
Copy link
Member

Is this rcparam actually used building the docs or is in just something we serve?

@klonuo
Copy link
ContributorAuthor

@jenshnielsen is this ok?

--- a/doc/make.py+++ b/doc/make.py@@ -38,7 +38,9 @@ def html(buildername='html'):     check_build()-    copy_if_out_of_date('../lib/matplotlib/mpl-data/matplotlibrc', '_static/matplotlibrc')+    rc = '../lib/matplotlib/mpl-data/matplotlibrc'+    rc = os.path.exists(rc) and rc or '../matplotlibrc.template'+    copy_if_out_of_date(rc, '_static/matplotlibrc')     if small_docs:         options = "-D plot_formats=png:80"     else:

@efiring
Copy link
Member

It looks like it is used only here:
http://matplotlib.org/users/customizing.html?highlight=matplotlibrc
in which case it is the template with only the backend specification uncommented. We could always use the template as-is, or we could always start with the template and make the single line modification to select a backend. This would make the docs build independent of the builder's platform, assuming there is a mechanism in place that assures default rcParams when making the plots for the docs.

@klonuo
Copy link
ContributorAuthor

So I guess we should referenceos.path.join(matplotlib._get_data_path(), 'matplotlibrc') instead?

That seems like default config, with only backend set.

@tacaswell
Copy link
Member

@klonuo I think that is correct.

Fallback to default "matplotlibrc" instead user's "matplotlibrc"
@jenshnielsenjenshnielsen merged commit2ac4e88 intomatplotlib:masterJun 13, 2016
@jenshnielsen
Copy link
Member

@klonuo Thanks

jenshnielsen added a commit that referenced this pull requestJun 13, 2016
@jenshnielsen
Copy link
Member

backported to 2.x as96fb3a3

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

5 participants
@klonuo@tacaswell@jenshnielsen@efiring@mdboom

[8]ページ先頭

©2009-2025 Movatter.jp