Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Update make.py#6530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update make.py#6530
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Referencingmatplotlib#6527, these changes provide: - fix for symlink exception on Windows - no need for rebuilding matplotlib from source
tacaswell commentedJun 3, 2016
@efiring I think this should fix your issue building the docs? |
jenshnielsen commentedJun 3, 2016
Im a bit worried about coping the users default rc file for generating the documentation. This can result in the documentation unintentionally being generated with a non default style. Would it not be better to refactor the code out from setup.py that generates the rc file from the template and call that as part of make.py? |
tacaswell commentedJun 3, 2016
Is this rcparam actually used building the docs or is in just something we serve? |
klonuo commentedJun 3, 2016
@jenshnielsen is this ok? --- a/doc/make.py+++ b/doc/make.py@@ -38,7 +38,9 @@ def html(buildername='html'): check_build()- copy_if_out_of_date('../lib/matplotlib/mpl-data/matplotlibrc', '_static/matplotlibrc')+ rc = '../lib/matplotlib/mpl-data/matplotlibrc'+ rc = os.path.exists(rc) and rc or '../matplotlibrc.template'+ copy_if_out_of_date(rc, '_static/matplotlibrc') if small_docs: options = "-D plot_formats=png:80" else: |
efiring commentedJun 3, 2016
It looks like it is used only here: |
klonuo commentedJun 4, 2016
So I guess we should reference That seems like default config, with only backend set. |
tacaswell commentedJun 4, 2016
@klonuo I think that is correct. |
Fallback to default "matplotlibrc" instead user's "matplotlibrc"
jenshnielsen commentedJun 13, 2016
@klonuo Thanks |
jenshnielsen commentedJun 13, 2016
backported to 2.x as96fb3a3 |
Referencing#6527, these changes provide: