Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Output pdf dicts in deterministic order#6427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Should we merge this as is or do you intend to add more commits to this? |
| r.extend([Name(key).pdfRepr() + b" " + pdfRepr(val) | ||
| for key, valin six.iteritems(obj)]) | ||
| r.extend([Name(key).pdfRepr() + b" " + pdfRepr(obj[key]) | ||
| for keyinsorted(six.iterkeys(obj))]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Theiterkeys seems unnecessary if you're going to sort it anyway;sorted(obj) should work just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, that makes sense.
@tacaswell I think it's probably better to merge sooner, it's going to be some work to implement the rest and this could make it easier for someone else to get started. |
For#6317 (but not a complete solution for that)