Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix #5998: Support fallback font correctly#6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 2 commits intomatplotlib:masterfrommdboom:mathfonts
Apr 12, 2016

Conversation

mdboom
Copy link
Member

@mdboommdboom added this to the2.0 (style change major release) milestoneMar 21, 2016
@mdboommdboom changed the titleFix #6015: Support fallback font correctlyFix #5998: Support fallback font correctlyMar 21, 2016
@@ -887,12 +887,12 @@ class DejaVuFonts(UnicodeFonts):

def __init__(self, *args, **kwargs):
# This must come first so the backend's owner is set correctly
TruetypeFonts.__init__(self, *args, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is the comment above still true?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, I think it turned out that this move wasn't necessary after all -- I had meant to revert it before committing. I'll do so now.

@zblz
Copy link
Member

Looks good to me! 👍

Do we have any idea why forcing an italics class was initially needed? Or was it just a bug?

@mdboom
Copy link
MemberAuthor

In the context of STIX falling back to Bakoma, it needs to be hardcoded toit because the symbols the fallback was needed for are only init. I think this was copied-and-pasted to the context of DejaVu falling back to STIX, where that is not the case.

@QuLogic
Copy link
Member

Are there no italic numbers? 05 vs 15?

I also wonder what is wrong with the baseline of the 't'.

@mdboom
Copy link
MemberAuthor

@QuLogic: That's correct. There are no italic circled numbers. Not sure what you mean by "05 vs. 15"

The baseline of t is a larger issue (addressed by#5414, but it will be some time to get that done). But that's not introduced by this PR.

@QuLogic
Copy link
Member

@QuLogic: That's correct. There are no italic circled numbers. Not sure what you mean by "05 vs. 15"

No, I didn't mean circled, just plain italic numbers, e.g.,mathfont_dejavusans_05.png vs.mathfont_dejavusans_15.png specifymathrm vs.mathit. But I see this is the case for the other fonts as well.

@mdboom
Copy link
MemberAuthor

Yes -- there are no italic numbers in any of these fonts.

@mdboom
Copy link
MemberAuthor

This is ready to merge.

@tacaswelltacaswell merged commit0db1152 intomatplotlib:masterApr 12, 2016
tacaswell added a commit that referenced this pull requestApr 12, 2016
Fix#5998: Support fallback font correctly
@tacaswell
Copy link
Member

backported to v2.x as819f746

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@mdboom@zblz@QuLogic@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp