Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make @cleanup *really* support generative tests.#6022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:cleanup-generative-tests-againFeb 18, 2016
Merged
Make @cleanup *really* support generative tests.#6022
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:cleanup-generative-tests-againFeb 18, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
'power cycled' to re-trigger build against new master. |
tacaswell added a commit that referenced this pull requestFeb 18, 2016
Make@cleanup *really* support generative tests.
Merging as I do not think the close/open cycle restarts appveyor. |
Does this need to be backported to 2.x? |
#5809 is actually milestoned to be on 1.5.2, though I'm not seeing it. |
This should be backported if we want to get#5785 into 2.x, no? |
tacaswell added a commit that referenced this pull requestMar 26, 2016
Make@cleanup *really* support generative tests.
bearstrong pushed a commit to bearstrong/matplotlib that referenced this pull requestApr 1, 2016
…sts-againMake@cleanup *really* support generative tests.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generative tests were still not run after#5809. If
f
is defined asdef f(): yield
,isgeneratorfunction(f) == isgenerator(f()) == True
.