Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support generative tests in @cleanup.#5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mdboom merged 4 commits intomatplotlib:masterfromanntzer:cleanup-generative-tests
Jan 25, 2016

Conversation

anntzer
Copy link
Contributor

All's in the title.

@anntzer
Copy link
ContributorAuthor

Rebased#5785 onto this, just to show that this implementation works.

@tacaswelltacaswell added this to thenext major release (2.0) milestoneJan 7, 2016
@tacaswell
Copy link
Member

👍 that is way simpler than I expected it to be!

@anntzer
Copy link
ContributorAuthor

Hum... I am pretty sure that thecleanup decorator (in its old version) made nose silently skiptest_axes.test_remove_shared_axes (the single failing test), which has then been (effectively) broken in some later commit. Can you investigate?

@tacaswell
Copy link
Member

Huh, good catch. I will try to take a look at that tomorrow.

@mdboom
Copy link
Member

Thanks. We were just talking about this in#5718.

@tacaswell
Copy link
Member

I do not have a clear memory of writing that test (but git blame tells me I did!). Sometimes I work in a tdd style where I just run the tests to check things so that test may have never worked.

For expediency of getting this merged, maybe throw a KnownFail on this create an issue telling me to fix the test.

@anntzer
Copy link
ContributorAuthor

Done. By the way, why was theprevious AppVeyor build successful even though the test suite failed? (I am a bit confused.)

@anntzer
Copy link
ContributorAuthor

I am even more confused by the new test failure. Anyone wants to take over this PR? (TBH I have little interest in investigating this.)

@tacaswell
Copy link
Member

Did you run these locally? That error is what happens if the test module is not importable.

@tacaswell
Copy link
Member

Turns out the fix is trivial, there is just an extraassert before theassert_array_equal. The function was not raising, so returningNone which fails the assert.

@tacaswell
Copy link
Member

I am going to do some local git merging to:

  • drop the second commit of this PR
  • add a commit to fix the test
  • backport the whole thing to v1.5.x

@tacaswell
Copy link
Member

Actually, I am having issues getting this to pass locally and am getting a large number of file not closed warnings, seeanntzer#1

@anntzer
Copy link
ContributorAuthor

Actually my original patch was wrong... can you see why? It's fixed now.

mdboom added a commit that referenced this pull requestJan 25, 2016
@mdboommdboom merged commitb3e576a intomatplotlib:masterJan 25, 2016
@mdboommdboom modified the milestones:Critical bug fix release (1.5.2),next major release (2.0)Jan 25, 2016
tacaswell pushed a commit that referenced this pull requestMar 26, 2016
@tacaswell
Copy link
Member

backported to v2.x as80be853

@tacaswelltacaswell added this to the2.0 (style change major release) milestoneMar 26, 2016
@tacaswelltacaswell removed this from the1.5.2 (Critical bug fix release) milestoneMar 26, 2016
bearstrong pushed a commit to bearstrong/matplotlib that referenced this pull requestApr 1, 2016
@anntzeranntzer deleted the cleanup-generative-tests branchJune 10, 2016 06:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@tacaswell@mdboom@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp