Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Build docs on python3.5 with linkcheck running on python 2.7#5797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Build docs on python3.5 with linkcheck running on python 2.7#5797
Uh oh!
There was an error while loading.Please reload this page.
Conversation
9fa3b3d to5edf56fCompare| @@ -86,8 +86,7 @@ install: | |||
| - | | |||
| if [[ $BUILD_DOCS == true ]]; then | |||
| pip install $PRE numpydoc ipython jsonschema mistune colorspacious | |||
| pip install -q $PRE linkchecker | |||
| pip install $PRE numpydoc ipython colorspacious | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have removed jsonshema and mistune they are not needed anymore. They were only there because ipython had a bud in its dependencies
In terms of catching bugs in and triggered by the examples, would it make sense to build the docs inboth Py3 and Py2 (in separate Travis configs so they run in parallel)? |
I have thought about that and it probably would. It's of cause a tradeoff between the time spend on building the docs vs how much more coverage it gives. Perhaps we should only do that after#5597 is merged? |
Build docs on python3.5 with linkcheck running on python 2.7
This is an alternative to#5338 which runs the yet not python 3.5 compatible linkchecker on python 2.7 but builds the docs with python 3.5