Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Choose offset text from ticks, not axes limits.#5780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:offsettext-uses-ticks-not-axes-limitsJan 1, 2016
Merged
Choose offset text from ticks, not axes limits.#5780
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:offsettext-uses-ticks-not-axes-limitsJan 1, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
tacaswell commentedJan 1, 2016
👍 This should get a png only image test (the example from#5738 is perfect). It looks like there is some low-hanging re-factoring possible here ( |
ContributorAuthor
anntzer commentedJan 1, 2016
I'm sort of hoping to just get this merged as-is and get a better test suite (not image based) / refactoring when working on#5755. |
Member
tacaswell commentedJan 1, 2016
Fair enough |
tacaswell added a commit that referenced this pull requestJan 1, 2016
…limitsChoose offset text from ticks, not axes limits.
tacaswell added a commit that referenced this pull requestJan 1, 2016
…limitsChoose offset text from ticks, not axes limits.
Member
tacaswell commentedJan 1, 2016
backported to 2.x asf52afbf |
anntzer added a commit to anntzer/matplotlib that referenced this pull requestJan 2, 2016
The axis offset text is choosen as follows:xlims => offsettext123, 189 => 012341, 12349 => 1234099999.5, 100010.5 => 100000 # (also a test formatplotlib#5780)99990.5, 100000.5 => 1000001233999, 1234001 => 1234000(and the same for negative limits).Seematplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this pull requestJan 2, 2016
The axis offset text is choosen as follows:xlims => offsettext123, 189 => 012341, 12349 => 1234099999.5, 100010.5 => 100000 # (also a test formatplotlib#5780)99990.5, 100000.5 => 1000001233999, 1234001 => 1234000(and the same for negative limits).Seematplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this pull requestJan 2, 2016
The axis offset text is chosen as follows:xlims => offsettext123, 189 => 012341, 12349 => 1234099999.5, 100010.5 => 100000 # (also a test formatplotlib#5780)99990.5, 100000.5 => 1000001233999, 1234001 => 1234000(and the same for negative limits).Seematplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this pull requestJan 7, 2016
The axis offset text is chosen as follows:xlims => offsettext123, 189 => 012341, 12349 => 1234099999.5, 100010.5 => 100000 # (also a test formatplotlib#5780)99990.5, 100000.5 => 1000001233999, 1234001 => 1234000(and the same for negative limits).Seematplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this pull requestJan 27, 2016
The axis offset text is chosen as follows:xlims => offsettext123, 189 => 012341, 12349 => 1234099999.5, 100010.5 => 100000 # (also a test formatplotlib#5780)99990.5, 100000.5 => 1000001233999, 1234001 => 1234000(and the same for negative limits).Seematplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this pull requestFeb 18, 2016
The axis offset text is chosen as follows:xlims => offsettext123, 189 => 012341, 12349 => 1234099999.5, 100010.5 => 100000 # (also a test formatplotlib#5780)99990.5, 100000.5 => 1000001233999, 1234001 => 1234000(and the same for negative limits).Seematplotlib#5755.
anntzer added a commit to anntzer/matplotlib that referenced this pull requestMay 2, 2016
The axis offset text is chosen as follows:xlims => offsettext123, 189 => 012341, 12349 => 1234099999.5, 100010.5 => 100000 # (also a test formatplotlib#5780)99990.5, 100000.5 => 1000001233999, 1234001 => 1234000(and the same for negative limits).Seematplotlib#5755.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the fix for#5738 was easier than expected.