I'll back out the inadvertent changes to the UAT notebook in a subsequent commit. (done).

Added toolbar.

We can't install the nb extension from a wheel, so I'd recommend the following: check for the existence of the nb extension when importingbackend_nbagg.py. If it does not exist, install it in the user directory. Provide a function to manually update the nb extension, and call that automatically when installing from source or from conda.

cc@ellisonbg@jdfreder@SylvainCorlay

The last commit implements the idea.

The UAT passes now, except forreshow, is that still needed@tacaswell?

Interact now works with nbagg (see demo above)!

Note to self: add an explicit "export" button instead of spitting out an image automatically when the widget is closed. (done).

Cool!

This is very cool. Thanks for taking this on.

Fixes#244

I don't see how this relates. Maybe wrong issue number?

We can't install the nb extension from a wheel, so I'd recommend the following: check for the existence of the nb extension when importing backend_nbagg.py. If it does not exist, install it in the user directory. Provide a function to manually update the nb extension, and call that automatically when installing from source or from conda.

Can you elaborate on this? It seems to add a lot of complexity for reasons that are lost to me, as someone who hasn't really followed Jupyter/IPython widgets. How does this work in the context where the matplotlib package is installed system-wide?

@mdboom, I removed the reference to 244, I can't find the issue I had meant to put there, it was referring to the fact that you could not "print" events to the notebook (as is now shown in the demo above).

For reference, installingbqplot is a two-step process, you install the source, and then install the nbextension. For a system-wide install, this could be done once. A conda recipe could load the extension in the current enviroment. Wheels are not allowed to execute code on installation, they just move source around to known Python locations.

https://github.com/bloomberg/bqplot#installation

@mdboom, found it:jupyter/notebook#244

Sorry, I still don't understand the need for the complexity of installing the Python code and Javascript code separately. Can't we get to the JavaScript code from where it's installed under the matplotlib package (as we do now)?

Untested, but 👍 in principle. Now that we are benefiting from hooking into the widget framework, do we also get a plot when the notebook page is refreshed? It might be worth going through the UATs and adding a refresh test.

Just want to say that this is awesome, I'm glad progress is being made on#5111.

@mdboom I think you're interested in what I've proposed here:jupyter/notebook#116

@jdfreder: Thanks for the pointer. Indeed, it looks at first glance thatjupyter/notebook#116 is moving in the direction that would really help us here. (It also helps me understand all the gory details and opposing requirements much better).

Hey all. And directly pinging@blink1073@SylvainCorlay@mdboom.

I'd really like to see this get merged into Matplotlib. I understand there are issues on the Jupyter side that may be holding this up.

I can devote some of my time (on the order of days, if necessary) to get this resolved. Can someone tell me what needs to be done and what I can do to move things forward?

Did jupyter settle how to do package and distribute the js side of the widgets?

@tacaswell I don't know the answer to that, and I'm not sure who to ask. Pinging@SylvainCorlay again (sorry), because I think he knows. I just want to volunteer my time and effort to finish this, and need some direction on what needs to be done.

If the packaging isn't solved, can we not just merge this as is and have a follow-up PR for that?

@SylvainCorlay, I am actually at a loss at the moment. I'm going to have to leave this to you.

I thought I had it working at one point, but I've spent all morning on this and have not gotten it figured out.

Yeah, I'm stumped here too.@SylvainCorlay, if you can drop in and save the day, that would be really cool.

Okay, I've almost got it sorted.

The latest change allows it to work, but the extension needs to installed on a per environment basis and enabled for the user in order to allow different versions per environment IIUC.

I just confirmed that it works on my local version of Jupyter 4.2. This is really great, thanks for picking this up again!

Re: Local installation. Isn't that the model for Jupyter now?

@tacaswell@blink1073 So, I've been using this branch for a few days now, and my understanding is it is done. Any chance we can get this merged into master? I wouldn't mind building a few things on top of it, but I'd rather do that after merge in separate, unrelated PRs.

I agree, this should be good to go.

I am going to merge this on the good word of@blink1073 .

If people were doing things in the notebook which relied on the previous version of the js we shipped we will re-address adding it back.

🎉

This is actually a pretty big deal -- we can arrange plots in the IPython notebook now. Great work,@blink1073!

👏

and callbacks that raise exceptions no longer get silently ignored 💯

Thanks everyone!! 🎉