@pwuertz may want to double check these, but in principle it seems fine to me.

We probably want to hold this up until#5724 is merged since that probably changes pgf_rcupdate2.pdf again

This should probably be backported to 2.x?

maybe waiting on#5772

Looks reasonable, and reminds me to check the test results from time to time. Some small details might be worth checking out (not related to this PR).

@pwuertz The tests should really be run on Travis. If I remember correctly the reason they are not is that the Travis images are based on Ubuntu 12.04 which ships a too old version of texlive (xetex). I tried switching to the new images in#5730 unfortunately that does not work with the Travis cache feature that we use.

Yea, the issue was that the setup for running the PGF tests was too heavy / uncommon so we decided to exclude them from the default set of tests. I guess this was even before we had a CI system / Travis. Could be possible to include the tests in such a controlled environment, but I don't know about the cache feature you mentioned.

The cache feature is not related to the pgf backend. It's there such that we don't have to build Numpy etc from scratch every time we run the tests. Unfortunatly it's not available on the Ubuntu 14.04 images.

I tried installing the pgf and zetex packages on this Travis node type unfortunately now a different test is failing (test_pdflatex) I guess this is due to an out of date version of texlive

I have installed the dependencies on Travis and refreshed all images. Lets hope that is enough to get the tests to pass.

This still needs to be hold of until#5724 and#5772 is merged to avoid regenerating the images multiple times

From looking at the tests on a Ubuntu 12.04 image the main reason for the needed tolerance seems to be the fonts selected. The 2 pdflatex test are different do to a different font whereas the xelatex one mainly seems to be due to different kerneling which may or may not be due to the font.

Regenerated the images on top of the new master. Still need to fix the font selection. The links below show the changes since github still does not due rich diffs for pdfs

• pgf_bbox_inches.pdf 1.5.x andpgf_bbox_inches.pdf This PR
• pgf_mixedmode.pdf 1.5.x andpgf_mixedmode.pdf This PR
• pgf_pdflatex.pdf 1.5.x andpgf_pdflatex.pdf This PR
• pgf_rcupdate1.pdf 1.5.x andpgf_rcupdate1.pdf This PR
• pgf_rcupdate2.pdf 1.5.x andpgf_rcupdate2.pdf This PR
• pgf_xelatex.pdf 1.5.x andpgf_xelatex.pdf This PR

By installing cm-super I should have been able to lover the diffs for two more tests to zero. Unfortunatly cm-super is not currently allowed on Travis. I will take care of that.

The final test still needs a diff of 4 to pass. From manual comparison it seems like it's only a text kerning issue but inspecting the pdf files seems to indicate that they are using different fonts.

pdffonts pgf_rcupdate1.pdf name                                 type              emb sub uni object ID------------------------------------ ----------------- --- --- --- ---------UKIXHV+LMRoman10-Regular-Identity-H  CID Type 0C       yes yes yes      6  0UDYZXV+LMSans17-Regular-Identity-H   CID Type 0C       yes yes yes      8  0EGPOOW+CMSY10                        Type 1C           yes yes no       9  0GOUKDS+CMMI12                        Type 1C           yes yes no      10  0EQCFIK+CMR17                         Type 1C           yes yes no      11  0ICUTZB+CMR12                         Type 1C           yes yes no      12  0

pdffonts expected_pgf_rcupdate1.pdf name                                 type              emb sub uni object ID------------------------------------ ----------------- --- --- --- ---------QXFOXX+LMSans17-Regular-Identity-H   CID Type 0C       yes yes yes      7  0CHCLNW+CMSY10                        Type 1C           yes yes no       8  0VLXDTR+CMMI12                        Type 1C           yes yes no       9  0ZOZAKN+CMR17                         Type 1C           yes yes no      10  0UQFOZG+CMR12                         Type 1C           yes yes no      11  0

This should finally be working. I have reduced all the tolerances to 0 apart from rc_update1 (see above)

I have rebased the changed on top of the now merged style changes pr#5774 (the pgf tests do not use the classic style) It is useful to verify the changes by comparing the pdf links above but I think they make sense.

Should this be backported to 2.x?

Yes I will do that as a pr