Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Set maximum number of bins in ticking#5724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jenshnielsen commentedDec 23, 2015
👍 I guess we can ignore the appveyor error? |
tacaswell commentedDec 31, 2015
This interacts with#5772 in a safe way, but we should probably centralize this logic in one place or the other. |
WeatherGod commentedDec 31, 2015
just thinking out loud, would it make sense to use a logarithm for the On Thu, Dec 31, 2015 at 2:30 PM, Thomas A Caswellnotifications@github.com
|
efiring commentedDec 31, 2015
On 2015/12/31 9:30 AM, Thomas A Caswell wrote:
If so, the logic definitely belongs in ticker, not in axis. It probably One could go farther, and argue that axis should only supply the |
efiring commentedDec 31, 2015
On 2015/12/31 9:44 AM, Benjamin Root wrote:
I don't understand; would you elaborate, please? How would a logarithm |
tacaswell commentedDec 31, 2015
I will rebase my PR on top of this one. |
WeatherGod commentedDec 31, 2015 via email
Sorry, I was typing with a baby in one arm...A hard-set limit to the number of bins would likely be fine in manysituations, but would 9 be enough when the axis is really long? A logarithmof the axis size could provide a way to have a dynamic maximum bin countthat grows very slowly with size. |
efiring commentedDec 31, 2015
@WeatherGod, I think using a log of the axis size would add more complexity than it would be worth. This is all for trying to automatically make a plot look decent on the screen. The axis size really can't get all that large. The very large case would be something like a poster; but at that point the user is going to need to specify all sorts of things manually anyway. |
jenshnielsen commentedJan 24, 2016
Any objections to merging this? |
Set maximum number of bins in ticking
efiring commentedJan 24, 2016
This is a clear and simple improvement that needs to go in, so I merged it. I suspect that somewhere along the line the tick strategy might need to be revisited, but that needn't block this incremental improvement. |
Follow-on to#5588 based on@efiring's comment that now there can be too many ticks. (#5588 (comment))