Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Set maximum number of bins in ticking#5724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
efiring merged 1 commit intomatplotlib:v2.xfrommdboom:tick-maximum
Jan 24, 2016

Conversation

mdboom
Copy link
Member

Follow-on to#5588 based on@efiring's comment that now there can be too many ticks. (#5588 (comment))

@mdboommdboom added this to thenext major release (2.0) milestoneDec 22, 2015
@jenshnielsen
Copy link
Member

👍 I guess we can ignore the appveyor error?

@tacaswell
Copy link
Member

This interacts with#5772 in a safe way, but we should probably centralize this logic in one place or the other.

@WeatherGod
Copy link
Member

just thinking out loud, would it make sense to use a logarithm for the
number of bins? I am imagining edge cases where users want really long time
series. we have had users hitting limits in the agg renderer before with
very big plots.

On Thu, Dec 31, 2015 at 2:30 PM, Thomas A Caswellnotifications@github.com
wrote:

This interacts with#5772
#5772 in a safe way, but
we should probably centralize this logic in one place or the other.


Reply to this email directly or view it on GitHub
#5724 (comment)
.

@efiring
Copy link
Member

On 2015/12/31 9:30 AM, Thomas A Caswell wrote:

This interacts with#5772
#5772 in a safe way, but
we should probably centralize this logic in one place or the other.

If so, the logic definitely belongs in ticker, not in axis. It probably
makes sense for ticker to handle the case of_tick_space == 0.

One could go farther, and argue that axis should only supply the
estimated label size and axis length, and leave everything else to the
ticker.

@efiring
Copy link
Member

On 2015/12/31 9:44 AM, Benjamin Root wrote:

just thinking out loud, would it make sense to use a logarithm for the
number of bins? I am imagining edge cases where users want really long time
series. we have had users hitting limits in the agg renderer before with
very big plots.

I don't understand; would you elaborate, please? How would a logarithm
be used?

@tacaswell
Copy link
Member

I will rebase my PR on top of this one.

@WeatherGod
Copy link
Member

WeatherGod commentedDec 31, 2015 via email

Sorry, I was typing with a baby in one arm...A hard-set limit to the number of bins would likely be fine in manysituations, but would 9 be enough when the axis is really long? A logarithmof the axis size could provide a way to have a dynamic maximum bin countthat grows very slowly with size.

@efiring
Copy link
Member

@WeatherGod, I think using a log of the axis size would add more complexity than it would be worth. This is all for trying to automatically make a plot look decent on the screen. The axis size really can't get all that large. The very large case would be something like a poster; but at that point the user is going to need to specify all sorts of things manually anyway.

@jenshnielsen
Copy link
Member

Any objections to merging this?

efiring added a commit that referenced this pull requestJan 24, 2016
Set maximum number of bins in ticking
@efiringefiring merged commit042ad99 intomatplotlib:v2.xJan 24, 2016
@efiring
Copy link
Member

This is a clear and simple improvement that needs to go in, so I merged it. I suspect that somewhere along the line the tick strategy might need to be revisited, but that needn't block this incremental improvement.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

5 participants
@mdboom@jenshnielsen@tacaswell@WeatherGod@efiring

[8]ページ先頭

©2009-2025 Movatter.jp