NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Fix twin remove#5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

WeatherGod merged 5 commits intomatplotlib:v1.5.xfromtacaswell:fix_twin_remove

Dec 15, 2015

Merged

Fix twin remove#5682

WeatherGod merged 5 commits intomatplotlib:v1.5.xfromtacaswell:fix_twin_remove

Dec 15, 2015

Conversation

Copy link

Member

tacaswell commentedDec 15, 2015

also adds tests tocbook.Grouper

This addresses half of#1312 use case by providing a clean way to remove shared axes.

tacaswell added4 commits

December 14, 2015 20:56

MNT: change to immutable default value

162e25b

ENH: add remove method to cbook.Grouper

2dfb60b

 - also add tests

TST: more tests of Grouper

db34cb7

This test touches the internals, if Grouper gets refactored thistest should be removed.

FIX/ENH: do more clean up when removing axes

0245db9

This adds clean up of the shared axes `Grouper` objects as partof removing an axes.`_reset_loc_form` is required because the locator/formatters end upbound to the axis objects of the last axes object (all of the Axes inthe group share the same formatter/locator objects but have differentAxis objects so that all but one of the Axis objects can be made notvisible to not over-draw).  If these are not re-bound to a still visibleaxes then changing the limits will change the view limits, but not thetick locations.closesmatplotlib#5663

tacaswell added the status: needs review label

Dec 15, 2015

TST: add test for removing axes with shared axis

f0a32b3

tacaswell added this to theCritical bugfix release (1.5.1) milestone

Dec 15, 2015